Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8026633686188084016=="
MIME-Version: 1.0
Subject: Review Request 27984: Jobs View UI link directs to last Tez Job seen
 instead of the one clicked
From: "Oleg Nechiporenko" <onechiporenko@apache.org>
To: "Andrii Tkach" <atkach@hortonworks.com>,
 "Alexandr Antonenko" <hiveww@gmail.com>
Cc: "Oleg Nechiporenko" <onechiporenko@apache.org>,
 "Ambari" <dev@ambari.apache.org>
Date: Thu, 13 Nov 2014 12:11:59 -0000
Message-ID: <20141113121159.11644.60578@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Oleg Nechiporenko" <noreply@reviews.apache.org>
Reply-To: "Oleg Nechiporenko" <onechiporenko@apache.org>

--===============8026633686188084016==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27984/
-----------------------------------------------------------

Review request for Ambari, Alexandr Antonenko and Andrii Tkach.


Bugs: ambari-8306
    https://issues.apache.org/jira/browse/ambari-8306


Repository: ambari


Description
-------

There's a javascript bug where the Jobs View links will go to the wrong job.
Setup:
1. Add the Jobs View (note that the URL properties must begin with "http://")
2. Change hive.execution.engine to tez
3. Run some sample jobs.
{code}
su - hive
cd /tmp
wget http://seanlahman.com/files/database/lahman591-csv.zip
unzip lahman591-csv.zip
hdfs dfs -copyFromLocal Schools.csv /tmp
hive
CREATE TABLE school (id STRING, name STRING, city STRING, state STRING, nick STRING) ROW FORMAT DELIMITED FIELDS TERMINATED BY '\054' STORED AS TEXTFILE;
LOAD DATA LOCAL INPATH '/tmp/Schools.csv' INTO TABLE school;
select state, count(id) as counts from school group by state sort by counts desc limit 10;
select name FROM school order by name asc limit 10;
{code}

Then visit the Jobs View, click on Job 1, then go back on the browser and click on Job 2 (and it will still show data from Job 1), then go back on the browser and click on Job 1 (and it will show data from Job 2).

I repro'ed this on Chrome and Firefox.


Diffs
-----

  contrib/views/jobs/src/main/resources/ui/app/scripts/views/job/hive_job_details_view.js 4d34e24 

Diff: https://reviews.apache.org/r/27984/diff/


Testing
-------

Tested manually.


Thanks,

Oleg Nechiporenko


--===============8026633686188084016==--