Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7137902506227521289=="
MIME-Version: 1.0
Subject: Re: Review Request 27819: Repository Version Management - Create API
 and BE support for update/delete repository version
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
Cc: "Yurii Shylov" <yurii.shylov@gmail.com>, "Ambari" <dev@ambari.apache.org>
Date: Wed, 12 Nov 2014 19:26:18 -0000
Message-ID: <20141112192618.17177.52819@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20141112111052.11644.22634@reviews.apache.org>
In-Reply-To: <20141112111052.11644.22634@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>

--===============7137902506227521289==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27819/#review61033
-----------------------------------------------------------


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
<https://reviews.apache.org/r/27819/#comment102497>

    If they only update the Display Name, even though that Repo Version is installed in clusters, I believe that operation should be allowed.


The rest of this looks good.

- Alejandro Fernandez


On Nov. 12, 2014, 11:10 a.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27819/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 11:10 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8211
>     https://issues.apache.org/jira/browse/AMBARI-8211
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create the following API: DELETE /api/v1/repository_versions/1
> PUT /api/v1/repository_versions/1
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java f9e8885 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 6fb1448 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java b39497c 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/CrudDAO.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java f0dcb44 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java 46476da 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 8e14bc1 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/RepositoryVersionServiceTest.java 94b4963 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 9dc4996 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 15fcb41 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/CrudDAOTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java 7dd3fab 
> 
> Diff: https://reviews.apache.org/r/27819/diff/
> 
> 
> Testing
> -------
> 
> Total run:693
> Total errors:0
> Total failures:0
> 
> Results :
> 
> Tests run: 2218, Failures: 0, Errors: 0, Skipped: 14
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


--===============7137902506227521289==--