Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6DA7610D0B for ; Tue, 11 Nov 2014 00:06:44 +0000 (UTC) Received: (qmail 56050 invoked by uid 500); 11 Nov 2014 00:06:44 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 56016 invoked by uid 500); 11 Nov 2014 00:06:44 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 56001 invoked by uid 99); 11 Nov 2014 00:06:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Nov 2014 00:06:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 324591DFDF0; Tue, 11 Nov 2014 00:06:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9086279402530646251==" MIME-Version: 1.0 Subject: Re: Review Request 27841: Ambari DB DDL create script doesn't properly create table cluster_version From: "Jonathan Hurley" To: "John Speidel" , "Sid Wagle" , "Jonathan Hurley" Cc: "Alejandro Fernandez" , "Ambari" Date: Tue, 11 Nov 2014 00:06:47 -0000 Message-ID: <20141111000647.17177.33429@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/27841/ X-Sender: "Jonathan Hurley" References: <20141110231445.19819.62706@reviews.apache.org> In-Reply-To: <20141110231445.19819.62706@reviews.apache.org> Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============9086279402530646251== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27841/#review60714 ----------------------------------------------------------- Ship it! Ship It! - Jonathan Hurley On Nov. 10, 2014, 6:14 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27841/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 6:14 p.m.) > > > Review request for Ambari, Jonathan Hurley, John Speidel, and Sid Wagle. > > > Bugs: AMBARI-8264 > https://issues.apache.org/jira/browse/AMBARI-8264 > > > Repository: ambari > > > Description > ------- > > The embedded DB creation sctipt: src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql incorrectly creates the cluster_version table in the wrong schema. > CREATE TABLE cluster_version (...) > It should be: > CREATE TABLE ambari.cluster_version (...) > This will cause a failure when creating a cluster stating that the relation cluster_version doesn't exist. > > > Diffs > ----- > > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a8b92e7 > > Diff: https://reviews.apache.org/r/27841/diff/ > > > Testing > ------- > > Copied the change sql file to a host after running yum install ambari-server -y and before ambari-server setup -s. > Then verified that the table was created correctly, > psql -U ambari -d ambari > \d > \d cluster_version > \d host_version > > > Thanks, > > Alejandro Fernandez > > --===============9086279402530646251==--