Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 52FFE17BEF for ; Fri, 7 Nov 2014 23:42:10 +0000 (UTC) Received: (qmail 67788 invoked by uid 500); 7 Nov 2014 23:42:10 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 67759 invoked by uid 500); 7 Nov 2014 23:42:10 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 67736 invoked by uid 99); 7 Nov 2014 23:42:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2014 23:42:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 706B71DFD20; Fri, 7 Nov 2014 23:42:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2177023511708117798==" MIME-Version: 1.0 Subject: Re: Review Request 27749: Updates HDP 2.1 stack config properties for App Timeline Service address From: "John Speidel" To: "John Speidel" , "Mahadev Konar" Cc: "Ambari" , "Robert Nettleton" Date: Fri, 07 Nov 2014 23:42:13 -0000 Message-ID: <20141107234213.10454.29756@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "John Speidel" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/27749/ X-Sender: "John Speidel" References: <20141107223338.12275.19307@reviews.apache.org> In-Reply-To: <20141107223338.12275.19307@reviews.apache.org> Reply-To: "John Speidel" X-ReviewRequest-Repository: ambari --===============2177023511708117798== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27749/#review60418 ----------------------------------------------------------- Ship it! Mahadev, Bob had to run out and I am in the process of another path. Can you merge this? - John Speidel On Nov. 7, 2014, 10:33 p.m., Robert Nettleton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27749/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 10:33 p.m.) > > > Review request for Ambari, John Speidel and Mahadev Konar. > > > Repository: ambari > > > Description > ------- > > This patch implements a fix for AMBARI-8217. > > The config properties for the App Timeline Service that deal with listening addresses previously used the "0.0.0.0" IP address. > > This causes problems for remote clients, which rely on this configuration in order to contact the App Timeline Server. > > This problem only manifests itself during a Blueprints Cluster install. > > This patch modifies three timeline-service address properties to use "localhost" as the default, rather than "0.0.0.0". This allows the Blueprint config processor to handle the substitution properly for these properties, and they will be updated with the hostname that includes the running App Timeline Service. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml dd67eb3 > > Diff: https://reviews.apache.org/r/27749/diff/ > > > Testing > ------- > > 1. Manually verified the fix against trunk. > > > Thanks, > > Robert Nettleton > > --===============2177023511708117798==--