Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B0E5517594 for ; Thu, 6 Nov 2014 16:16:03 +0000 (UTC) Received: (qmail 23163 invoked by uid 500); 6 Nov 2014 16:16:03 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 23134 invoked by uid 500); 6 Nov 2014 16:16:03 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 23087 invoked by uid 99); 6 Nov 2014 16:16:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2014 16:16:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C39B21DFC2A; Thu, 6 Nov 2014 16:16:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3588190275576685601==" MIME-Version: 1.0 Subject: Re: Review Request 27635: Repository Version Management - Create API and BE support for creating/retrieving repo versions From: "Nate Cole" To: "Alejandro Fernandez" , "Nate Cole" , "Dmitro Lisnichenko" Cc: "Yurii Shylov" , "Ambari" Date: Thu, 06 Nov 2014 16:16:06 -0000 Message-ID: <20141106161606.10455.47581@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/27635/ X-Sender: "Nate Cole" References: <20141106161403.10454.36529@reviews.apache.org> In-Reply-To: <20141106161403.10454.36529@reviews.apache.org> Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============3588190275576685601== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27635/#review60175 ----------------------------------------------------------- Ship it! Ship It! - Nate Cole On Nov. 6, 2014, 11:14 a.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27635/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 11:14 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-8164 > https://issues.apache.org/jira/browse/AMBARI-8164 > > > Repository: ambari > > > Description > ------- > > Create API and BE support for creating/retrieving repository versions > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191 > ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6 > ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c > ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb > ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java PRE-CREATION > ambari-server/src/test/java/org/apache/ambari/server/api/services/RepositoryVersionServiceTest.java PRE-CREATION > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java PRE-CREATION > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/27635/diff/ > > > Testing > ------- > > Results : > > Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14 > > ... > > Total run: 684 > Total errors:0 > Total failures:0 > > > Thanks, > > Yurii Shylov > > --===============3588190275576685601==--