Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E94E1783E for ; Wed, 5 Nov 2014 00:16:14 +0000 (UTC) Received: (qmail 61882 invoked by uid 500); 5 Nov 2014 00:16:14 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 61847 invoked by uid 500); 5 Nov 2014 00:16:14 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 61809 invoked by uid 99); 5 Nov 2014 00:16:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Nov 2014 00:16:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E15591DFB9D; Wed, 5 Nov 2014 00:16:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2677371893096848257==" MIME-Version: 1.0 Subject: Re: Review Request 27590: Upgrade Execute: Create API endpoint for upgrades and upgrade items From: "Alejandro Fernandez" To: "Alejandro Fernandez" , "Tom Beerbower" , "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Wed, 05 Nov 2014 00:16:17 -0000 Message-ID: <20141105001617.10455.1912@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/27590/ X-Sender: "Alejandro Fernandez" References: <20141105001555.10455.1282@reviews.apache.org> In-Reply-To: <20141105001555.10455.1282@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============2677371893096848257== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 5, 2014, 12:15 a.m., Alejandro Fernandez wrote: > > Ship It! Thanks for getting this out there so quickly. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27590/#review59885 ----------------------------------------------------------- On Nov. 4, 2014, 9:55 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27590/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 9:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower. > > > Bugs: AMBARI-8144 > https://issues.apache.org/jira/browse/AMBARI-8144 > > > Repository: ambari > > > Description > ------- > > Added stubs for /api/v1/clusters/c1/upgrades > > This test does not provide full DB connectivity. It's only meant to unblock other teams from having an endpoint to work with. There will be many many more changes over the course of the Upgrades initiative > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/StaticallyInject.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java f5de481 > ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeItemResourceDefinition.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java ab71ce2 > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeItemService.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeService.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 14e5dc8 > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 0974f6f > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java de63db5 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java b665813 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java PRE-CREATION > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/27590/diff/ > > > Testing > ------- > > Only basic test added, more to come as functionality fills out. > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 30:48.302s > [INFO] Finished at: Tue Nov 04 16:54:11 EST 2014 > [INFO] Final Memory: 29M/248M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============2677371893096848257==--