Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 753A3178C8 for ; Sun, 2 Nov 2014 16:37:13 +0000 (UTC) Received: (qmail 47248 invoked by uid 500); 2 Nov 2014 16:37:13 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 47214 invoked by uid 500); 2 Nov 2014 16:37:13 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 47197 invoked by uid 99); 2 Nov 2014 16:37:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Nov 2014 16:37:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B692D1DFA87; Sun, 2 Nov 2014 16:37:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7600012017195222331==" MIME-Version: 1.0 Subject: Review Request 27488: Configs: not prompted when changes are not saved when clicking on scv From: "Andrii Tkach" To: "Srimanth Gunturi" , "Aleksandr Kovalenko" , "Alexandr Antonenko" Cc: "Andrii Tkach" , "Ambari" Date: Sun, 02 Nov 2014 16:37:16 -0000 Message-ID: <20141102163716.10454.98720@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Andrii Tkach" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/27488/ X-Sender: "Andrii Tkach" Reply-To: "Andrii Tkach" X-ReviewRequest-Repository: ambari --===============7600012017195222331== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27488/ ----------------------------------------------------------- Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Srimanth Gunturi. Bugs: AMBARI-8107 https://issues.apache.org/jira/browse/AMBARI-8107 Repository: ambari Description ------- If I make a config change, and attempt to navigate away prior to saving, I am prompted that i have changes to cancel/discard/save if I click on another service, or a top main nav. If I click on another service config version, I am not prompted and then lose my changes. Diffs ----- ambari-web/app/controllers/main/service/info/configs.js 3a873e0 ambari-web/app/templates/common/configs/config_history_flow.hbs 68d6b11 ambari-web/app/templates/common/configs/service_version_box.hbs 8bd8434 ambari-web/app/views/common/configs/config_history_flow.js 2e3a3e4 ambari-web/test/controllers/main/service/info/config_test.js aace90b Diff: https://reviews.apache.org/r/27488/diff/ Testing ------- 4826 tests complete (8 seconds) 60 tests pending Thanks, Andrii Tkach --===============7600012017195222331==--