Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F479C284 for ; Wed, 12 Nov 2014 22:43:37 +0000 (UTC) Received: (qmail 3608 invoked by uid 500); 12 Nov 2014 22:43:37 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 3579 invoked by uid 500); 12 Nov 2014 22:43:37 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 3567 invoked by uid 99); 12 Nov 2014 22:43:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Nov 2014 22:43:37 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of eboyd@redhat.com designates 209.132.183.24 as permitted sender) Received: from [209.132.183.24] (HELO mx3-phx2.redhat.com) (209.132.183.24) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Nov 2014 22:43:32 +0000 Received: from zmail13.collab.prod.int.phx2.redhat.com (zmail13.collab.prod.int.phx2.redhat.com [10.5.83.15]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id sACMfAFK018861; Wed, 12 Nov 2014 17:41:10 -0500 Date: Wed, 12 Nov 2014 17:41:09 -0500 (EST) From: Erin Boyd To: dev@ambari.apache.org, Nate Cole Message-ID: <1066949484.1108768.1415832069923.JavaMail.zimbra@redhat.com> In-Reply-To: <20141112214928.17177.4379@reviews.apache.org> References: <20141112213433.11644.63943@reviews.apache.org> <20141112214928.17177.4379@reviews.apache.org> Subject: Re: Review Request 27929: Alerts: Remove Nagios Remnants From Ambari Server Code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF27 (Mac)/8.0.6_GA_5922) Thread-Topic: Review Request 27929: Alerts: Remove Nagios Remnants From Ambari Server Code Thread-Index: Wn33b3kavPUKGJUSZr7KkBLEi1d7YQ== X-Virus-Checked: Checked by ClamAV on apache.org me too! :) ----- Original Message ----- From: "Nate Cole" To: "Nate Cole" , "Tom Beerbower" Cc: "Ambari" , "Jonathan Hurley" Sent: Wednesday, November 12, 2014 2:49:28 PM Subject: Re: Review Request 27929: Alerts: Remove Nagios Remnants From Ambari Server Code ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27929/#review61081 ----------------------------------------------------------- Ship it! This change fills me with happiness :) - Nate Cole On Nov. 12, 2014, 4:34 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27929/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 4:34 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-8300 > https://issues.apache.org/jira/browse/AMBARI-8300 > > > Repository: ambari > > > Description > ------- > > Remove the following artifacts left over in the ambari-server codebase: > > - Passive Info structures on the agent commands and heartbeat > - References to Nagios as a service or component > - Maintenance states that were Nagios-specific > > I was not able to remove the NagiosPropertyProvider since the web client depends on it. Therefore, I just have it NO-OPing with deprecation annotations. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/Role.java 2de7ade > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java f0614e4 > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java ed4d39c > ambari-server/src/main/java/org/apache/ambari/server/agent/NagiosAlertCommand.java bdf9039 > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryGroupedRenderer.java a7309f1 > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 1899dde > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java da7a9da > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7e95ac8 > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java d21f81b > ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 459f01f > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java ae20f56 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 5a98364 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java f66fc1d > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java c93ef29 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java ed376c4 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java e45b5c7 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java a4b2667 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertSummaryPropertyProvider.java d952ae7 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java 1caaa22 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java f183141 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 077d8f3 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java facc670 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java eb6237d > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java cd22340 > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosAlert.java 1d58430 > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 5b93db8 > ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 63d8760 > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 5d78201 > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 4339f60 > ambari-server/src/main/resources/key_properties.json c1a6636 > ambari-server/src/main/resources/properties.json ad59922 > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java e1e25e0 > ambari-server/src/test/java/org/apache/ambari/server/controller/MaintenanceStateHelperTest.java 9b4ce29 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java b7e8ced > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java 3d9f331 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java 49caffc > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java 22c30bc > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java eef05f6 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java ce623ed > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessorTest.java 7eb28df > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 48b9077 > > Diff: https://reviews.apache.org/r/27929/diff/ > > > Testing > ------- > > Updated tests to reflect the removed code. > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 12:05 min > [INFO] Finished at: 2014-11-12T16:33:32-05:00 > [INFO] Final Memory: 30M/596M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >