ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-8122) Correct Issues Pointed Out In Git 32187893edabcfc29f1cfb4961146566c2215433
Date Tue, 04 Nov 2014 20:57:33 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196796#comment-14196796
] 

Hudson commented on AMBARI-8122:
--------------------------------

SUCCESS: Integrated in Ambari-trunk-Commit #824 (See [https://builds.apache.org/job/Ambari-trunk-Commit/824/])
AMBARI-8122. Correct Issues Pointed Out In Git 32187893edabcfc29f1cfb4961146566c2215433 (dlysnichenko)
(dlysnichenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=ca12fe4360fa1c8c1efb98c27cca92e194e550b8)
* ambari-server/src/test/resources/os_family.json
* ambari-server/src/main/resources/os_family.json
* ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java
* ambari-server/src/test/java/org/apache/ambari/server/state/stack/OSFamilyTest.java


> Correct Issues Pointed Out In Git 32187893edabcfc29f1cfb4961146566c2215433
> --------------------------------------------------------------------------
>
>                 Key: AMBARI-8122
>                 URL: https://issues.apache.org/jira/browse/AMBARI-8122
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.0.0
>            Reporter: Dmitry Lysnichenko
>            Assignee: Dmitry Lysnichenko
>             Fix For: 2.0.0
>
>         Attachments: AMBARI-8122.patch
>
>
> There are some issues with https://github.com/apache/ambari/commit/32187893edabcfc29f1cfb4961146566c2215433:
> 1) Code review only has 1 committer reviewing.
> 2) Exception caught int OSFamily should be rethrown as part of unchecked
> 3) Close os_family.json stream properly
> 4) Provide new tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message