ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 28405: Distribute Repositories/Install Components - server part
Date Fri, 28 Nov 2014 02:10:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/#review63253
-----------------------------------------------------------

Ship it!


Looks good.  If this is dependent on another review, please coordinate to make sure tests
pass.  We can't have a broken trunk.  We can live (for now) without new tests, but we sure
can't break existing ones.


ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java
<https://reviews.apache.org/r/28405/#comment105427>

    What about if just this.clusterName == null?


- Nate Cole


On Nov. 27, 2014, 3:26 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28405/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2014, 3:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8434
>     https://issues.apache.org/jira/browse/AMBARI-8434
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Preview version of patch. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java
ed94877 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
c4ad169 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java
86a00a8 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java
95d8963 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
a1ece2c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
0e65a1d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
0fc590e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
83f0e0f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
67e62d7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/NoSuchParentResourceException.java
308841f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java
de1c9dd 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079

>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java
960a485 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 51fc9e1 
>   ambari-server/src/test/python/custom_actions/configs/install_packages_config.json 1055a40

> 
> Diff: https://reviews.apache.org/r/28405/diff/
> 
> 
> Testing
> -------
> 
> manual verification on 2-node cluster
> 
> proper unit test coverage is pending
> 
> 
> File Attachments
> ----------------
> 
> patch_27.11
>   https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message