ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jun aoki" <jun.aoki....@gmail.com>
Subject Re: Review Request 28458: AMBARI-8438 ambari build in docker to open Java debug port.
Date Wed, 26 Nov 2014 22:49:57 GMT


> On Nov. 26, 2014, 9:34 p.m., Alejandro Fernandez wrote:
> > Ship It!

Thx Alejandro!


- jun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28458/#review63139
-----------------------------------------------------------


On Nov. 26, 2014, 12:24 a.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28458/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 12:24 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-8438
>     https://issues.apache.org/jira/browse/AMBARI-8438
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> docker run command described [https://github.com/apache/ambari/blob/trunk/dev-support/docker/README.md
| here ] does provide JDK debug port 5005 but ambari-server is not started with --debug option
enabled. ambaribuild.py should have an option to enable it. 
> 
> Also added a few minor tweak like 'git clean' is an externalized option and and show
build duration.
> 
> 
> Diffs
> -----
> 
>   dev-support/docker/README.md 6613e0d 
>   dev-support/docker/docker/Dockerfile 96ba8ff 
>   dev-support/docker/docker/bin/ambaribuild.py 66df31f 
>   dev-support/docker/docker/bin/test/ambaribuild_test.py 223fa98 
> 
> Diff: https://reviews.apache.org/r/28458/diff/
> 
> 
> Testing
> -------
> 
> Test passed.
> 
> 
> Thanks,
> 
> jun aoki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message