ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yurii Shylov" <yurii.shy...@gmail.com>
Subject Re: Review Request 27810: Alerts: SNMP Target for Notifications
Date Wed, 26 Nov 2014 17:18:57 GMT


> On Ноя. 10, 2014, 4:09 п.п., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java,
line 30
> > <https://reviews.apache.org/r/27810/diff/1/?file=756757#file756757line30>
> >
> >     Public fields should be capitalized.
> 
> Yurii Shylov wrote:
>     Sun's convention says that fields should be in camelCase, and I haven't found any
specific rules for Ambari which would imply that they should be capitalized
> 
> Jonathan Hurley wrote:
>     Ambari's convention for public, non-encapsulated fields has been to use a capitalized
word.
> 
> Yurii Shylov wrote:
>     Where can I check for Ambari's conventions? I was using https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari.
Can you talk with Yusaku to update that document?
> 
> Jonathan Hurley wrote:
>     Sure, we can get the document updated. It actually doesn't mention public fields
naming conventions, so we'll need to add that.

As the wiki wasn't updated and I haven't seen any other Ambari files following the suggested
convention, the field names are still named according to java's default convention. I'll add
Yusaku to review to clarify this.


- Yurii


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review60609
-----------------------------------------------------------


On Ноя. 26, 2014, 5:13 п.п., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
> 
> (Updated Ноя. 26, 2014, 5:13 п.п.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-8251
>     https://issues.apache.org/jira/browse/AMBARI-8251
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have
been received and not yet processed for outbound notification. On a schedule, Ambari will
determine the alert targets that should be receiving some sort of notification and then it
will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act
as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust,
customizable notifications.
> 
> 
> Diffs
> -----
> 
>   ambari-server/pom.xml e03b626 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java
9514474 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java
e690e76 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java
12dffd7 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java
10946be 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b

>   ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java
f979c03 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java
69f3393 
>   ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java
1e7689f 
>   ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java
2e984bf 
> 
> Diff: https://reviews.apache.org/r/27810/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [4.589s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
> [INFO] Ambari Web ........................................ SUCCESS [52.018s]
> [INFO] Ambari Views ...................................... SUCCESS [15.517s]
> [INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
> [INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
> [INFO] Ambari Agent ...................................... SUCCESS [28.370s]
> [INFO] Ambari Client ..................................... SUCCESS [0.733s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.351s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.639s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:04.344s
> [INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
> [INFO] Final Memory: 58M/676M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message