ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Shkvyra" <dshkv...@hortonworks.com>
Subject Re: Review Request 20609: Deleted slave components stick around from the service's perspective
Date Mon, 24 Nov 2014 15:17:08 GMT


> On Ноя. 24, 2014, 3:08 п.п., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java,
line 2625
> > <https://reviews.apache.org/r/20609/diff/5/?file=774114#file774114line2625>
> >
> >     In this scenario we are deleting the host component. Do we need this state check?
What if the host component is in INSTALL_FAILED or INIT or some other state where it can be
deleted. Should we not let the exclude file be cleaned in that case?

This patch just recommit (clear excludes) and mark their master (need restart) only for components
which were decommited before deletion, so these components should be in INSTALLED state, othewise
we do not need clear excludes and restrt masters.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20609/#review62769
-----------------------------------------------------------


On Ноя. 24, 2014, 12:13 п.п., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20609/
> -----------------------------------------------------------
> 
> (Updated Ноя. 24, 2014, 12:13 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5544 and AMBARI-5589
>     https://issues.apache.org/jira/browse/AMBARI-5544
>     https://issues.apache.org/jira/browse/AMBARI-5589
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We should set the state to INIT when the last host component gets removed
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
4103621 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
9d3a1f8 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/hdfs_namenode.py
5500b97 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py
fc53b44 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/package/scripts/params.py
b942d03 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py
15c0ef0 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py
1900598 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py
ed4d7bf 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py
49ac408 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py
5e066d9 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
7a194a4 
>   ambari-server/src/test/python/TestAmbariServer.py caa87cc 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py 086fa2b 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_namenode.py 49ad368 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default_update_exclude_file_only.json
PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 465f42b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e12e19 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_update_exclude_file_only.json
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20609/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [3.651s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.350s]
> [INFO] Ambari Web ........................................ SUCCESS [8.150s]
> [INFO] Ambari Views ...................................... SUCCESS [7.956s]
> [INFO] Ambari Server ..................................... SUCCESS [12:29.721s]
> [INFO] Ambari Agent ...................................... SUCCESS [29.804s]
> [INFO] Ambari Client ..................................... SUCCESS [0.562s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:23.772s
> [INFO] Finished at: Wed Apr 23 17:13:04 FET 2014
> [INFO] Final Memory: 27M/262M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message