ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szilard Nemethy" <sneme...@hortonworks.com>
Subject Re: Review Request 27284: Ability to support umask 027
Date Mon, 24 Nov 2014 13:27:51 GMT


> On Nov. 18, 2014, 2:22 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py,
line 51
> > <https://reviews.apache.org/r/27284/diff/2/?file=762020#file762020line51>
> >
> >     So the server does a+x, but the agent is o+x?  Any user should be able to invoke
'java'

Made this consistent with server permissions (a+x).


> On Nov. 18, 2014, 2:22 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/files/setupGanglia.sh,
line 121
> > <https://reviews.apache.org/r/27284/diff/2/?file=762021#file762021line121>
> >
> >     Why x?  There should be no runnables in this directory?

Good point. Removed execution permissions.


- Szilard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27284/#review61918
-----------------------------------------------------------


On Nov. 19, 2014, 2:30 p.m., Szilard Nemethy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27284/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2014, 2:30 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Nate Cole.
> 
> 
> Bugs: AMBARI-7796
>     https://issues.apache.org/jira/browse/AMBARI-7796
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ability to support umask 027
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari-server.py 91deb74 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
e657002 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
126b8bb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
7022993 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/files/setupGanglia.sh
e700eaa 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py
c38366f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase.py
d312f0b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py
32b5307 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_datanode.py
c93c6e4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py
ed4d7bf 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_snamenode.py
49241b4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py
de18c88 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/service_check.py
81d7ca5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py
fd9bbfa 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py
c2b038d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py
c1279d8 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/files/oozieSmoke2.sh
c355704 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py
bab1d78 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py
71d1492 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/pig.py
afdba8d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py
5e066d9 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py
1333004 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/package/scripts/falcon.py
d3e1f2f 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/package/scripts/params.py
e652fff 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/package/scripts/params.py
50f6d73 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/package/scripts/tez.py
37c9512 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 317635f 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py b22677b 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 8ce021e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 3531e3e

>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 465f42b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 91446d2 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e12e19 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py d77164b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 16d3f19 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py d4c7b26 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 4e1ad93 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py d99ac5c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py b6d5597 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 51eabbd 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 5004242 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 05882b6 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 004afb4 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py da43b8d 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d19b263 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py 552da62

>   ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
cec41b7 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py edc2318 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 590e234 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 57a91d8 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py a988751 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 1d2f980 
> 
> Diff: https://reviews.apache.org/r/27284/diff/
> 
> 
> Testing
> -------
> 
> Unit testing.
> End to end testing with and without HA and Security.
> 
> 
> Thanks,
> 
> Szilard Nemethy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message