ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 28095: Add Kerberos State to Ambari database
Date Fri, 21 Nov 2014 16:27:24 GMT


> On Nov. 20, 2014, 11:35 p.m., Jonathan Hurley wrote:
> > I'm still not clear on the relationship of ServiceImpl to the host components when
security is enabled. I would have expected to see logic that cascades the securtiy setting
from the service to the components of that service. But perhaps that's just me misunderstanding
the requirements of this service. Aside from that, it's just the Oracle SQL issue I pointed
out.

This may be an issue with trying to split up a larger patch into smaller chunks.  If I understand
what your are misunderstaning, I think the disconnect is how this data will be used.  Essentially
at some point we will need to know whether a component needs to be _secured_ or _unsecured_.
 To do this we need to know whether it's relevant service's desired _security state_ is set
to `OFF` or some particular type (i.e., Kerberos).  So then when interrogating each compenet
on whether they should or should not be secured in some way we first check to see if the relevant
service should be. I suppose that we can do this at the cluster level, or rely on the cluster-env
security_enabled value, but we may want to at some point declare a particular service as not
_securable_.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28095/#review62520
-----------------------------------------------------------


On Nov. 20, 2014, 4:21 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28095/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 4:21 p.m.)
> 
> 
> Review request for Ambari, dilli dorai, Jonathan Hurley, John Speidel, Robert Nettleton,
Sid Wagle, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8336
>     https://issues.apache.org/jira/browse/AMBARI-8336
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In order to track which services and components have been or need to be _Kerberized_
several tables need to be updated with a {{kerberos_state}} column to contain one the following
values:
> 
> * `UNKNOWN` - Indicates the state is unknown
> * `OFF` - Indicates the service or component is not or should not be Kerberized
> * `ON` - Indicates the service or component is or should be Kerberized
> * `IN_PROGRESS` - Indicates the component is in the process of being Kerberized 
> * `ERROR` - Indicates the component cannot or failed to be Kerberized
> 
> The following tables need to be updated:
> 
> * hostcomponentdesiredstate - To indicate whether the component needs Kerberos added
or removed (`OFF`, `ON`)
> * hostcomponentstate - To indicate whether the component is currently configured for
Kerberos or not (`OFF`, `IN_PROGRESS`, `ON`, `ERROR`, `UNKNOWN`)
> * servicedesiredstate - To indicate whether the service (and it components) should or
should not be Kerberized (`OFF`, `ON`)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java
610f77f 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
81de777 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
a74b021 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ComponentKerberosState.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 4a18c69 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
3142974 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4b4a305

>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceKerberosState.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
606751d 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
45e7813 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 493291d

>   ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
5410ee3 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
6a5bab7 
> 
> Diff: https://reviews.apache.org/r/28095/diff/
> 
> 
> Testing
> -------
> 
> Java Unit Tests:
> Tests run: 2250, Failures: 0, Errors: 0, Skipped: 14
> 
> Manual tests to verifty tables are altered and values are updated.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message