ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Review Request 28332: Unit Testing Improvments : Examine AmbariManagementControllerTest
Date Fri, 21 Nov 2014 15:55:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28332/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower.


Bugs: AMBARI-8413
    https://issues.apache.org/jira/browse/AMBARI-8413


Repository: ambari


Description
-------

In an effort to reduce the amount of time it takes to run the unit tests we should examine
slowest of them and see if we can make improvements through the use of mocks or common setup
or something else.
5.609torg.apache.ambari.server.controller.AmbariManagementControllerTest.testCreateClusterSimple
4.721torg.apache.ambari.server.controller.AmbariManagementControllerTest.testApplyConfigurationWithTheSameTag
2.027torg.apache.ambari.server.controller.AmbariManagementControllerTest.testCreateClusterWithInvalidStack
1.839torg.apache.ambari.server.controller.AmbariManagementControllerTest.testMaintenanceAndDeleteStates
1.741torg.apache.ambari.server.controller.AmbariManagementControllerTest.testReConfigureServiceClient
1.737torg.apache.ambari.server.controller.AmbariManagementControllerTest.testInstallAndStartService
1.71torg.apache.ambari.server.controller.AmbariManagementControllerTest.testDeleteClusterCreateHost
1.673torg.apache.ambari.server.controller.AmbariManagementControllerTest.testCreateClusterWithHostMapping
1.668torg.apache.ambari.server.controller.AmbariManagementControllerTest.testHbaseDecommission
1.619torg.apache.ambari.server.controller.AmbariManagementControllerTest.testCreateServicesSimple
1.614torg.apache.ambari.server.controller.AmbariManagementControllerTest.testScheduleSmokeTest


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462

  ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
1484698 

Diff: https://reviews.apache.org/r/28332/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [3.184s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.477s]
[INFO] Ambari Web ........................................ SUCCESS [39.229s]
[INFO] Ambari Views ...................................... SUCCESS [4.208s]
[INFO] Ambari Admin View ................................. SUCCESS [11.066s]
[INFO] Ambari Server ..................................... SUCCESS [20:20.869s]
[INFO] Ambari Agent ...................................... SUCCESS [6.205s]
[INFO] Ambari Client ..................................... SUCCESS [0.038s]
[INFO] Ambari Python Client .............................. SUCCESS [0.257s]
[INFO] Ambari Groovy Client .............................. SUCCESS [9.891s]
[INFO] Ambari Shell ...................................... SUCCESS [0.030s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.034s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [6.533s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS


Thanks,

Dmytro Sen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message