ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 28291: Alerts: Template Engine for Dispatching
Date Fri, 21 Nov 2014 04:07:17 GMT


> On Nov. 20, 2014, 9:52 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java,
line 125
> > <https://reviews.apache.org/r/28291/diff/1/?file=771332#file771332line125>
> >
> >     Nit: does this still work even if there's no markup in the body?  If someone
_wanted_ plain text?

If there's no markup in the body, then this will instruct the mail client to show the text
as-is. It will still be flagged as html, but should render as plaintext. A plaintext-only
client, however, might have issues displaying it b/c of how the message is constructed. There
were no requirements to support plaintext-only clients, so I didn't bother with 2 types of
email templates.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28291/#review62517
-----------------------------------------------------------


On Nov. 20, 2014, 2:16 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28291/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 2:16 p.m.)
> 
> 
> Review request for Ambari, Nate Cole, Srimanth Gunturi, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8400
>     https://issues.apache.org/jira/browse/AMBARI-8400
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari's various dispatchers (such as Email and SNMP) can benefit from having a mechanism
where a template can be defined for the construction of notification data. This decouples
the content that Ambari is sending from the logic to compute the aggregate alerts.
> 
> Apache Velocity is a good choice for this requirement as it includes a maturing template
language, VTL. 
> 
> A single XML file that ships with Ambari will contain the default templates for known
alert target types. There will be an option to override the use of this file with a user-specified
location via ambari.properties. In the event that a user-specific XML file cannot be parsed,
appropriate exceptions will be thrown, but the {{AlertNoticeDispatchService}} will attempt
to gracefully fallback on other content rendering options (such as the internal XML file).
> 
> The following data should be exposed to VTL:
> 
> - a list of all alert changes
> -- alert name, state, date, label
> -- a list for each state change
> -- lists for all alerts, broke down by service and state 
> 
> - a list of all services with an alert
> - a list of all hosts with an alert
> 
> - total counts of changes separated
> -- one count for each alert state
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/AmbariService.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/api/query/render/AlertSummaryGroupedRenderer.java
0dbeb5c 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
0a96193 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java
13f2da2 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java
a5dad84 
>   ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java
72487b3 
>   ambari-server/src/main/resources/alert-templates.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/alerts.json 96cb931

>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/alerts.json 11836b3

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json e58c4a3

>   ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28291/diff/
> 
> 
> Testing
> -------
> 
> New tests written to cover dispatch service.
> 
> mvn clean test
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:35 min
> [INFO] Finished at: 2014-11-20T14:16:02-05:00
> [INFO] Final Memory: 33M/617M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message