ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xi Wang" <xw...@hortonworks.com>
Subject Re: Review Request 28259: Remove legacy Nagios alerts code from Ambari Web
Date Thu, 20 Nov 2014 20:22:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28259/
-----------------------------------------------------------

(Updated Nov. 20, 2014, 12:22 p.m.)


Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Bugs: AMBARI-8388
    https://issues.apache.org/jira/browse/AMBARI-8388


Repository: ambari


Description
-------

Nagios is no longer available as a service in trunk.
Ambari Web needs to remove calls to get legacy_alerts, as this will no longer work once the
server code removes the provider for Nagios alerts.
As part of this ticket, remove legacy_alerts from being requested and make sure that the general
UI does not break.


Diffs (updated)
-----

  ambari-web/app/assets/test/tests.js c831716 
  ambari-web/app/controllers.js c4385ce 
  ambari-web/app/controllers/global/update_controller.js bfb625c 
  ambari-web/app/controllers/main/alerts_controller.js b28f711 
  ambari-web/app/controllers/main/host.js dc966db 
  ambari-web/app/messages.js 9943582 
  ambari-web/app/routes/main.js 361312b 
  ambari-web/app/templates/main/dashboard/alert_notification_popup.hbs 8a37e23 
  ambari-web/app/templates/main/host/alerts_popup.hbs 247753a 
  ambari-web/app/templates/main/service/info/summary.hbs 8ccc64e 
  ambari-web/app/utils/ajax/ajax.js d4a8402 
  ambari-web/app/views/main/dashboard/widgets.js 29b7063 
  ambari-web/app/views/main/service/info/summary.js 99c049b 
  ambari-web/test/controllers/main/alerts_controller_test.js aee782a 
  ambari-web/test/views/main/service/info/summary_test.js f64ee18 

Diff: https://reviews.apache.org/r/28259/diff/


Testing
-------

tested


Thanks,

Xi Wang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message