ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 28194: Alerts UI: Alert Definition API should provide a 'description' field
Date Wed, 19 Nov 2014 13:29:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28194/#review62153
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Nov. 19, 2014, 8:25 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28194/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2014, 8:25 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-8377
>     https://issues.apache.org/jira/browse/AMBARI-8377
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Alerts UI needs a title and a description for alert definitions. We have the {{label}}
property for the title. We need a {{description}} property to describe what this alert-definition
does. 
> Default alert-definitions provided in stack could have better description about themselves.
> 
> {{AlertDefinition/description}} will be added for this. We'll include descriptions on
{{alerts.json}} in HDFS for this Jira, and then a new Jira will cover getting descriptions
into the other JSON files.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AlertDefinitionResponse.java
c6de8fe 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
ccc71f1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
a66a916 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
9f2ec07 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
c694f90 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
a85a5d0 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4fa4be1 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 5092332 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql fb666df 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql bb3fa5f 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 2993cbf 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json ed0f4a6

>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
faaafa6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java
c1567dc 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java
0643301 
>   ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionEqualityTest.java
1ee1224 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
f2c4053 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
64bdbca 
>   ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json 202488c

> 
> Diff: https://reviews.apache.org/r/28194/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:54 min
> [INFO] Finished at: 2014-11-18T09:04:37-05:00
> [INFO] Final Memory: 30M/606M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message