ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters
Date Tue, 18 Nov 2014 11:38:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61900
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
<https://reviews.apache.org/r/28124/#comment103828>

    As of now, RepositoryVersionEntity seems to restrict repository version values only to
those that are installed for a stack, right?
    I consider the workflow when host contains some stale repo files that remained after server
reset or after previous cluster deployment. Are we able to display via API stale repository
versions that are installed on a host?


- Dmitro Lisnichenko


On Nov. 17, 2014, 6:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 6:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java
14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java
e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1

>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java
aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java
72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java
7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java
c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java
42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message