ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 28095: Add Kerberos State to Ambari database
Date Mon, 17 Nov 2014 15:34:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28095/#review61728
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/state/KerberosState.java
<https://reviews.apache.org/r/28095/#comment103590>

    I think it may make sense to add two enum values to make the cases of when a service should
or should not be Kerberized simpler.  
    
    From what I can see here, it looks like a given enum value (ON or OFF) is meant to be
interpreted differently, based on the table that the value is found in.  
    
    Perhaps it would make sense to consider adding "REQUIRED" and "NOT_SUPPORTED" as enum
values (or some other strings that mean the same thing) in order to make this case a little
clearer. 
    
    This doesn't seem like a big problem.  I'm just bringing this up as a possible maintenance
issue in the future.


- Robert Nettleton


On Nov. 17, 2014, 2:45 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28095/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 2:45 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, John Speidel, Robert Nettleton, Sid Wagle,
and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8336
>     https://issues.apache.org/jira/browse/AMBARI-8336
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In order to track which services and components have been or need to be _Kerberized_
several tables need to be updated with a {{kerberos_state}} column to contain one the following
values:
> 
> * `UNKNOWN` - Indicates the state is unknown
> * `OFF` - Indicates the service or component is not or should not be Kerberized
> * `ON` - Indicates the service or component is or should be Kerberized
> * `IN_PROGRESS` - Indicates the component is in the process of being Kerberized 
> * `ERROR` - Indicates the component cannot or failed to be Kerberized
> 
> The following tables need to be updated:
> 
> * hostcomponentdesiredstate - To indicate whether the component needs Kerberos added
or removed (`OFF`, `ON`)
> * hostcomponentstate - To indicate whether the component is currently configured for
Kerberos or not (`OFF`, `IN_PROGRESS`, `ON`, `ERROR`, `UNKNOWN`)
> * servicedesiredstate - To indicate whether the service (and it components) should or
should not be Kerberized (`OFF`, `ON`)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java
610f77f 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
81de777 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
a74b021 
>   ambari-server/src/main/java/org/apache/ambari/server/state/KerberosState.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 4a18c69 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
3142974 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4b4a305

>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
606751d 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
45e7813 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 493291d

>   ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
5410ee3 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
6a5bab7 
> 
> Diff: https://reviews.apache.org/r/28095/diff/
> 
> 
> Testing
> -------
> 
> Java Unit Tests:
> Tests run: 2250, Failures: 0, Errors: 0, Skipped: 14
> 
> Manual tests to verifty tabes are altered and values are updated.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message