ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 27700: Allow for server-side commands
Date Sun, 16 Nov 2014 13:42:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27700/
-----------------------------------------------------------

(Updated Nov. 16, 2014, 8:42 a.m.)


Review request for Ambari, dilli dorai, Jonathan Hurley, John Speidel, Nate Cole, Robert Nettleton,
and Sid Wagle.


Changes
-------

Updated `Stage.addServerActionCommand` to allow for command parameters, updated javadoc.

This was needed to make specifying command parameters a but easier. 


Bugs: AMBARI-7985
    https://issues.apache.org/jira/browse/AMBARI-7985


Repository: ambari


Description
-------

Ambari currently handles client-/agent-side commands; however there is no ability to handle
server-side commands. Server-side commands should be specified as a task in a stage and managed
along with the stage.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
1f99b4a 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
5e879cc 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java e2fad5f

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
81fee75 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java bbc5ac3 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java d74510a

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 6920a9e

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/AbstractServerAction.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerAction.java be885b5

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionManager.java
011cf06 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionManagerImpl.java
3a16c77 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHostEvent.java
78590fc 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHostEventType.java
b43ac9c 
  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostServerActionEvent.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostUpgradeEvent.java
8b375fe 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
36acbc2 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java
5a2c467 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
7224924 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 6e78b1d

  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
2d898e5 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/MockServerAction.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/ServerActionExecutorTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/27700/diff/


Testing (updated)
-------

Ran all tests in ambari-server
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:17.258s
[INFO] Finished at: Sun Nov 16 08:02:43 EST 2014
[INFO] Final Memory: 43M/1324M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message