ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mahadev Konar" <maha...@apache.org>
Subject Re: Review Request 28101: Views: Remove NOT NULL constraint from instance data and property tables.
Date Sat, 15 Nov 2014 23:18:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28101/#review61670
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On Nov. 15, 2014, 11:02 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28101/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2014, 11:02 p.m.)
> 
> 
> Review request for Ambari and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-8345
>     https://issues.apache.org/jira/browse/AMBARI-8345
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The viewinstancedata and viewinstanceproperty tables have a NOT NULL constraint on the
VALUE column.
> With Oracle, the empty string is stored as a null value which violates the constraint.
> Remove the constraint from both tables.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
65b669a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e496ae6 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f9c87b0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6a8ecd4 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 30c840c 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
d456101 
> 
> Diff: https://reviews.apache.org/r/28101/diff/
> 
> 
> Testing
> -------
> 
> All tests pass ...
> 
> Results :
> 
> Tests run: 2112, Failures: 0, Errors: 0, Skipped: 15
> 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:16 min
> [INFO] Finished at: 2014-11-15T17:51:14-05:00
> [INFO] Final Memory: 46M/475M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message