ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 27998: Repository Version Management - Add validation for created repo versions
Date Fri, 14 Nov 2014 17:12:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27998/#review61454
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Nov. 14, 2014, 4:35 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27998/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 4:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8314
>     https://issues.apache.org/jira/browse/AMBARI-8314
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add some validation when creating a repo version:
> * validate the stack exists
> * upgrade pack specified is available for the stack
> * validate the OS specified for repositories are all in the stack available
> * validate that the version specified is valid for the upgrade pack.  this will involve
changing the upgrade pack "target" element to a regex appropriately
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
502a94e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
2debfd3 
> 
> Diff: https://reviews.apache.org/r/27998/diff/
> 
> 
> Testing
> -------
> 
> 3 python tests fail, but they fail on trunk as well. Java test ok, this patch affects
only java code
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message