ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andriy Babiichuk" <ababiic...@hortonworks.com>
Subject Re: Review Request 27877: UI only loads content property from stack for *-env.xml, others are ignored
Date Fri, 14 Nov 2014 16:27:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27877/
-----------------------------------------------------------

(Updated Ноя. 14, 2014, 4:27 п.п.)


Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-8281
    https://issues.apache.org/jira/browse/AMBARI-8281


Repository: ambari


Description
-------

Currently all properties except _content_ one from *-env.xml configurations files should be
duplicated in _ambari-web/app/data/HDP2/site_properties.js_ .
Otherwise they are ignored on service deploy (not added to ambari configs).

More details:
It looks like UI has some property values for services hardcoded and hidden from user. These
include _hbase.tmp.dir_ and bunch of others.
When user makes changes to configs these properties are added to corresponding configs and
sent to server.
Issue is that UI probably filters them by property name only, so if other service has property
with same name, this property will not be shown to user and, which is more important, will
not be sent to server as it is wired to another service.

We are adding new service which contains embedded hbase, so we have config with all duplicated
hbase properties, as result it is impossible to create correct configuration via UI.


Diffs (updated)
-----

  ambari-web/app/controllers/wizard/step7_controller.js 5b2a904 
  ambari-web/app/models/service_config.js 36ac180 
  ambari-web/app/utils/config.js cb44f36 
  ambari-web/test/controllers/wizard/step7_test.js 4b100af 

Diff: https://reviews.apache.org/r/27877/diff/


Testing
-------

  5027 tests complete (6 seconds)
  60 tests pending


Thanks,

Andriy Babiichuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message