ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 27871: Provide a way to get service-specific Kerberos descriptor via REST API
Date Wed, 12 Nov 2014 18:03:00 GMT


> On Nov. 11, 2014, 5:11 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java,
line 148
> > <https://reviews.apache.org/r/27871/diff/1/?file=757999#file757999line148>
> >
> >     This is a good idea but might not be enough.  
> >     
> >     In the case where someone has a partial response request for ?fields= StackServices,
it should return all of the properties under that category.
> >     
> >     Also, we support requesting a single element of a map property so in theory
someone could make a request like ?fields= StackServices/kerberos_descriptor/someProperty.
> >     
> >     I think in both of those cases the check would fail when we really do want to
get the descriptor.
> >     
> >     We need a method that has the logic of setResourceProperty that simply checks
and returns a boolean.

Removed in [revision 2](https://reviews.apache.org/r/27871/diff/2/)


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/#review60862
-----------------------------------------------------------


On Nov. 12, 2014, 1:02 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27871/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 1:02 p.m.)
> 
> 
> Review request for Ambari, dilli dorai, John Speidel, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8247
>     https://issues.apache.org/jira/browse/AMBARI-8247
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Provide a way for a caller via the REST API to get information about a service's Kerberos
descriptor. This information should probably be attached to a service resource response.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
2794c18 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
1296ba1 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b

>   ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 279361b

>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 9277ec6

>   ambari-server/src/main/resources/properties.json ad59922 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
6ab35c2 
>   ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java 225213f

>   ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/27871/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message