ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xi Wang" <xw...@hortonworks.com>
Subject Re: Review Request 27763: Alerts UI: Create Manage Alerts Group dialog
Date Tue, 11 Nov 2014 22:23:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27763/
-----------------------------------------------------------

(Updated Nov. 11, 2014, 2:22 p.m.)


Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi.


Changes
-------

Patch updated. With full functions of this dialog including add/remove/rename/duplicate Alert
Group, and add/remove definitions of a group.


Bugs: AMBARI-8221
    https://issues.apache.org/jira/browse/AMBARI-8221


Repository: ambari


Description
-------

We want a dialog to manage alert groups per service. 
Users should be able to see the list of alert groups, and view the alert definitions configured
in them. 
User should be able to add/remove alert definitions, and pick notification for that alert
group.


Diffs (updated)
-----

  ambari-web/app/assets/data/alerts/alertGroup.json PRE-CREATION 
  ambari-web/app/assets/data/alerts/alertGroups.json PRE-CREATION 
  ambari-web/app/controllers.js 146840f 
  ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js e6a5c33 
  ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js PRE-CREATION 
  ambari-web/app/messages.js 4464534 
  ambari-web/app/models.js df19e28 
  ambari-web/app/models/alert_group.js PRE-CREATION 
  ambari-web/app/templates/main/alerts/add_definition_to_group_popup.hbs PRE-CREATION 
  ambari-web/app/templates/main/alerts/create_new_alert_group.hbs PRE-CREATION 
  ambari-web/app/templates/main/alerts/manage_alert_groups_popup.hbs PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js ef26ba8 
  ambari-web/app/utils/validator.js fb51d4b 
  ambari-web/app/views.js ff40a9f 
  ambari-web/app/views/main/alerts/manage_alert_groups_view.js PRE-CREATION 

Diff: https://reviews.apache.org/r/27763/diff/


Testing
-------


Thanks,

Xi Wang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message