ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 27810: Alerts: SNMP Target for Notifications
Date Mon, 10 Nov 2014 16:09:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review60609
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java
<https://reviews.apache.org/r/27810/#comment101977>

    Public fields should be capitalized.



ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java
<https://reviews.apache.org/r/27810/#comment101978>

    Public fields should be capitalized.



ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java
<https://reviews.apache.org/r/27810/#comment101979>

    Public fields should be capitalized.



ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment101981>

    SNMPv2 PDU types are not supported by this. Should this be a determination based on the
supplied properties?


- Jonathan Hurley


On Nov. 10, 2014, 10:49 a.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 10:49 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-8251
>     https://issues.apache.org/jira/browse/AMBARI-8251
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have
been received and not yet processed for outbound notification. On a schedule, Ambari will
determine the alert targets that should be receiving some sort of notification and then it
will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act
as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust,
customizable notifications.
> 
> 
> Diffs
> -----
> 
>   ambari-server/pom.xml 4e7477e 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java
9514474 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java
13f2da2 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java
12dffd7 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java
10946be 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b

>   ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java
a5dad84 
>   ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java
72487b3 
>   ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java
1e7689f 
>   ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27810/diff/
> 
> 
> Testing
> -------
> 
> Total run:693
> Total errors:0
> Total failures:0
> OK
> 
> Results :
> 
> Tests run: 2225, Failures: 0, Errors: 0, Skipped: 14
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message