ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 27730: Upgrade Execute: Load and parse upgrade packs from stack directory
Date Mon, 10 Nov 2014 12:58:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27730/#review60585
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
<https://reviews.apache.org/r/27730/#comment101938>

    Not sure if error message is relevant here. How about (debug?) logging entire stack trace?



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
<https://reviews.apache.org/r/27730/#comment101940>

    mistype here?


- Dmitro Lisnichenko


On Nov. 7, 2014, 7:51 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27730/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 7:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8206
>     https://issues.apache.org/jira/browse/AMBARI-8206
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Initial file for upgrade pack.
> 
> Note for xml transfer objects, there is no need for explicit getters on all those objects,
so they were left as-is for now.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
3d67fe9 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
781ea13 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 224cce4

>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 242cfcc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Batch.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConditionalBatch.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/CountBatch.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml PRE-CREATION

>   ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
PRE-CREATION 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/27730/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:03.553s
> [INFO] Finished at: Fri Nov 07 10:55:25 EST 2014
> [INFO] Final Memory: 29M/252M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message