ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yurii Shylov" <yurii.shy...@gmail.com>
Subject Re: Review Request 27635: Repository Version Management - Create API and BE support for creating/retrieving repo versions
Date Thu, 06 Nov 2014 12:59:49 GMT


> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java,
lines 114-116
> > <https://reviews.apache.org/r/27635/diff/1/?file=750580#file750580line114>
> >
> >     Not knowing how people will name repos, is it possible the same name can be
used between stacks?  What if they name it simply "2.3"?
> 
> Dmitro Lisnichenko wrote:
>     FYI: some repos like HDP-UTILS seem to be shared between upgrade versions.

We should encourage people to give meaningful names for repositories. Its name is the first
thing they'll look at in UI, and if we allow duplicates for names, it will rize the probability
to make a mistake.
In this context display_name is the name of the whole repositories set, so it doesn't matter
that HDP-UTILS will be the same.


> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java,
lines 56-60
> > <https://reviews.apache.org/r/27635/diff/1/?file=750582#file750582line56>
> >
> >     Use daoUtils here - there's a convenience method that handles this for us

Fixed.


> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 82
> > <https://reviews.apache.org/r/27635/diff/1/?file=750585#file750585line82>
> >
> >     We'd like to stop one-lining definitions.  See how the alert tables were defined.

Fixed.


> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/resources/META-INF/persistence.xml, line 72
> > <https://reviews.apache.org/r/27635/diff/1/?file=750589#file750589line72>
> >
> >     Keep these in alphabetic order

They were not sorted. Anyway, fixed, now they are.


> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/resources/key_properties.json, lines 164-166
> > <https://reviews.apache.org/r/27635/diff/1/?file=750590#file750590line164>
> >
> >     Do this in code instead.  This file's use is no longer necessary.

Fixed.


> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/resources/properties.json, lines 458-467
> > <https://reviews.apache.org/r/27635/diff/1/?file=750591#file750591line458>
> >
> >     Do this in code instead.  This file's use is no longer necessary.

Fixed.


- Yurii


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60003
-----------------------------------------------------------


On Ноя. 6, 2014, 12:59 п.п., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
> 
> (Updated Ноя. 6, 2014, 12:59 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8164
>     https://issues.apache.org/jira/browse/AMBARI-8164
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create API and BE support for creating/retrieving repository versions
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
c611191 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
52b0ba6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
a5f5b05 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
cb6c271 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
14c385d 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c 
>   ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb 
> 
> Diff: https://reviews.apache.org/r/27635/diff/
> 
> 
> Testing
> -------
> 
> Results :
> 
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
> 
> ...
> 
> Total run: 684
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message