ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 27607: Rolling Upgrade Bootstrap - Create new tables and populate during the installation of a new cluster
Date Wed, 05 Nov 2014 21:35:37 GMT


> On Nov. 5, 2014, 4:33 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java,
lines 127-131
> > <https://reviews.apache.org/r/27607/diff/1/?file=750126#file750126line127>
> >
> >     After reading http://www.developerscrappad.com/228/java/java-ee/ejb3-jpa-dealing-with-date-time-and-timestamp/
> >     and
> >     http://www.objectdb.com/java/jpa/entity/types#Date_and_Time_Temporal_Types_
> >     
> >     I think it's clearer to use the current java.util.Date class with @Temporal
TIMESTAMP

The rest of the system (except for Users, not sure what happened there) uses the long timestamp.
 Let's keep consistent.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27607/#review60000
-----------------------------------------------------------


On Nov. 4, 2014, 11:30 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27607/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 11:30 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, Sid Wagle,
and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8148
>     https://issues.apache.org/jira/browse/AMBARI-8148
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Create new tables and populate during the installation of a new cluster.
> 
> *clusterversion* table
> Column    | Type       | Keys | Example
> ----------|------------|------|---------------------------------------------
> id        |BIGINT      |PK    |1
> cluster_id|BIGINT      |FK    |2
> stack     |VARCHAR(255)|      |HDP-2.2 
> version   |VARCHAR(255)|      |HDP-2-2.0.1-885 
> state     |VARCHAR(32) |      |INSTALLED, CURRENT, UPGRADING, UPGRADE_FAILED 
> start_time|DATETIME    |      |2014-10-31 14:00:00
> end_time  |DATETIME    |      |2014-10-31 15:00:00
> user_name |VARCHAR(32) |      |admin
> 
> *hostcomponentstate* table
> Add column upgrade_state VARCHAR(32) ("NONE" is the default, "UPGRADING", "UPGRADE_FAILED")
> 
> *hostversion* table
> Column   |Type        |Keys         |Example
> ---------|------------|-------------|----------------------------------
> id       |BIGINT      |PK           |1
> host_name|VARCHAR(255)|FK hosts.name|c6401.ambari.apache.org
> stack    |VARCHAR(255)|             |HDP-2.2
> version  |VARCHAR(255)|             |2.2.0.1-885
> state    |VARCHAR(32) |             |INSTALLED, CURRENT, NOT_INSTALLED
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
b030ea1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
7dce204 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostEntity.java a71fddb

>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/HostComponentUpgradeState.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/HostVersionState.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
3718556 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
bc97936 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
14c385d 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c 
>   ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb 
>   ambari-server/src/test/python/TestAmbariServer.py c3651eb 
> 
> Diff: https://reviews.apache.org/r/27607/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests
> 
> ambari-server unit tests
> ----------------------------------------------------------------------
> Total run:684
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message