ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 27635: Repository Version Management - Create API and BE support for creating/retrieving repo versions
Date Wed, 05 Nov 2014 19:42:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60003
-----------------------------------------------------------


Looking good!  Just some minor comments below.


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
<https://reviews.apache.org/r/27635/#comment101341>

    Not knowing how people will name repos, is it possible the same name can be used between
stacks?  What if they name it simply "2.3"?



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
<https://reviews.apache.org/r/27635/#comment101343>

    Use daoUtils here - there's a convenience method that handles this for us



ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
<https://reviews.apache.org/r/27635/#comment101347>

    We'd like to stop one-lining definitions.  See how the alert tables were defined.



ambari-server/src/main/resources/META-INF/persistence.xml
<https://reviews.apache.org/r/27635/#comment101351>

    Keep these in alphabetic order



ambari-server/src/main/resources/key_properties.json
<https://reviews.apache.org/r/27635/#comment101349>

    Do this in code instead.  This file's use is no longer necessary.



ambari-server/src/main/resources/properties.json
<https://reviews.apache.org/r/27635/#comment101350>

    Do this in code instead.  This file's use is no longer necessary.


- Nate Cole


On Nov. 5, 2014, 2:15 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 2:15 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8164
>     https://issues.apache.org/jira/browse/AMBARI-8164
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create API and BE support for creating/retrieving repository versions
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
c611191 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
4f69dbb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
52b0ba6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
a5f5b05 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
cb6c271 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
14c385d 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c 
>   ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb 
>   ambari-server/src/main/resources/key_properties.json c1a6636 
>   ambari-server/src/main/resources/properties.json 36cff96 
> 
> Diff: https://reviews.apache.org/r/27635/diff/
> 
> 
> Testing
> -------
> 
> Results :
> 
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
> 
> ...
> 
> Total run: 684
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message