ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saman Alvi" <sa...@pivotal.io>
Subject Re: Review Request 27625: Background operation notification plurality should match number of operations
Date Wed, 05 Nov 2014 17:41:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27625/#review59982
-----------------------------------------------------------

Ship it!


Ship It!

- Saman Alvi


On Nov. 5, 2014, 5:30 p.m., Anthony Penniston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27625/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 5:30 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-7924
>     https://issues.apache.org/jira/browse/AMBARI-7924
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The notification for background operations should reflect the number of currently running
operations in its plurality. For example, a single operation should be displayed as "1 op"
all other operation counts should be shown as "# ops"
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/messages.js 6625a38 
>   ambari-web/app/templates/application.hbs 1796a27 
>   ambari-web/app/utils/helper.js 5a25b8f 
> 
> Diff: https://reviews.apache.org/r/27625/diff/
> 
> 
> Testing
> -------
> 
> verify "0 ops" when no background operations running.
> trigger operation via Service Actions, verify "1 op" displays
> trigger another concurrent operation, verify "2 ops" display
> trigger another concurrent operation, verify "3 ops" display
> 
> 
> File Attachments
> ----------------
> 
> 1 op
>   https://reviews.apache.org/media/uploaded/files/2014/11/05/9a5fc381-bb77-464d-bb1e-2a72521bd580__Screen_Shot_2014-11-03_at_4.07.17_PM.png
> 2 ops
>   https://reviews.apache.org/media/uploaded/files/2014/11/05/d645d185-33a2-4692-90c3-5a2f0e870ea0__Screen_Shot_2014-11-03_at_4.07.33_PM.png
> 
> 
> Thanks,
> 
> Anthony Penniston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message