ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xi Wang" <xw...@hortonworks.com>
Subject Re: Review Request 27547: UI: Change "dfs.namenode.safemode.threshold-pct" value if HA enabled
Date Tue, 04 Nov 2014 23:29:34 GMT


> On Nov. 4, 2014, 2:01 p.m., Jaimin Jetly wrote:
> > ambari-web/app/utils/config.js, line 1299
> > <https://reviews.apache.org/r/27547/diff/2/?file=749589#file749589line1299>
> >
> >     We might not want to introduce this function over here.
> >     
> >     So on enabling HA when we go to HDFS page, this config will be changed by the
new code:
> >     1) An undo sign will be present without user having made any changes expicitly
and navigating out of this page will warn user to save the change before navigating.
> >     2) User will not be able to change this config value via UI. If user changes
this config then it will be saved successfully but after that again 0.99f will appear as the
value of the config forcing it to save the config with only this value. 
> >     
> >     Instead I suggest to update this config with 0.99f only once on NameNode HA
wizard (Review page that displays all properties that will change as part of this wizard)

Thanks, Jaimin. Added this as a property on HA wizard review page. Tested. Unit tests passed.


- Xi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27547/#review59848
-----------------------------------------------------------


On Nov. 4, 2014, 3:26 p.m., Xi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27547/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 3:26 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: Ambari-8129
>     https://issues.apache.org/jira/browse/Ambari-8129
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> hdfs-site.xml
> Change value of "dfs.namenode.safemode.threshold-pct" to "0.99f" if NN HA
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/data/HDP2/ha_properties.js 2b34b8b 
>   ambari-web/app/utils/config.js 2f157e8 
> 
> Diff: https://reviews.apache.org/r/27547/diff/
> 
> 
> Testing
> -------
> 
> Tested patch before/after NN HA enabled. Unit tests passed.
> 
> 
> Thanks,
> 
> Xi Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message