ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vitalyi Brodetskyi" <vbrodets...@hortonworks.com>
Subject Re: Review Request 27532: Correct Issues Pointed Out In Git 32187893edabcfc29f1cfb4961146566c2215433
Date Tue, 04 Nov 2014 17:34:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27532/#review59779
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Лис. 3, 2014, 7:27 після полудня, Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27532/
> -----------------------------------------------------------
> 
> (Updated Лис. 3, 2014, 7:27 після полудня)
> 
> 
> Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-8122
>     https://issues.apache.org/jira/browse/AMBARI-8122
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There are some issues with https://github.com/apache/ambari/commit/32187893edabcfc29f1cfb4961146566c2215433:
> 1) Code review only has 1 committer reviewing.
> 2) Exception caught int OSFamily should be rethrown as part of unchecked
> 3) Close os_family.json stream properly
> 4) Provide new tests
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java b024cfe

>   ambari-server/src/main/resources/os_family.json 6638ea5 
>   ambari-server/src/test/java/org/apache/ambari/server/state/stack/OSFamilyTest.java
PRE-CREATION 
>   ambari-server/src/test/resources/os_family.json 7314fd0 
> 
> Diff: https://reviews.apache.org/r/27532/diff/
> 
> 
> Testing
> -------
> 
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [4.438s]
> [INFO] Ambari Server ..................................... SUCCESS [24:46.093s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:51.447s
> [INFO] Finished at: Mon Nov 03 20:17:39 EET 2014
> [INFO] Final Memory: 45M/884M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message