Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 48F9F174CF for ; Tue, 28 Oct 2014 13:11:46 +0000 (UTC) Received: (qmail 86800 invoked by uid 500); 28 Oct 2014 13:11:46 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 86773 invoked by uid 500); 28 Oct 2014 13:11:46 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 86405 invoked by uid 99); 28 Oct 2014 13:11:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Oct 2014 13:11:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 313FA1DF55F; Tue, 28 Oct 2014 13:11:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1574395709251543736==" MIME-Version: 1.0 Subject: Review Request 27281: Add UI unit tests for Slider View controllers From: "Aleksandr Kovalenko" To: "Andriy Babiichuk" Cc: "Aleksandr Kovalenko" , "Ambari" Date: Tue, 28 Oct 2014 13:11:50 -0000 Message-ID: <20141028131150.7138.83739@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aleksandr Kovalenko" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/27281/ X-Sender: "Aleksandr Kovalenko" Reply-To: "Aleksandr Kovalenko" X-ReviewRequest-Repository: ambari --===============1574395709251543736== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27281/ ----------------------------------------------------------- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-8000 https://issues.apache.org/jira/browse/AMBARI-8000 Repository: ambari Description ------- Cover the following files with unit tests: * controllers/create_app_wizard_controller.js * controllers/slider_app_controller.js * controllers/slider_apps_controller.js * controllers/slider_controller.js Diffs ----- contrib/views/slider/src/main/resources/ui/test/unit/controllers/create_app_wizard_controller_test.js PRE-CREATION contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_app_controller_test.js 2f9512c contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_apps_controller_test.js PRE-CREATION contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_controller_test.js 0ec84c8 contrib/views/slider/src/main/resources/ui/test/unit/views/common/table_view_test.js PRE-CREATION contrib/views/slider/src/main/resources/ui/test/unit/views/slider_apps_view_test.js d287d7f Diff: https://reviews.apache.org/r/27281/diff/ Testing ------- Thanks, Aleksandr Kovalenko --===============1574395709251543736==--