Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A212D17CC7 for ; Mon, 27 Oct 2014 19:15:11 +0000 (UTC) Received: (qmail 99100 invoked by uid 500); 27 Oct 2014 19:15:10 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 99076 invoked by uid 500); 27 Oct 2014 19:15:10 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 98901 invoked by uid 99); 27 Oct 2014 19:15:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Oct 2014 19:15:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BD3D71DF672; Mon, 27 Oct 2014 19:15:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6377441449161283831==" MIME-Version: 1.0 Subject: Re: Review Request 27230: Alerts: Convert Script-Style HDFS and Hive Alerts From Nagios From: "Nate Cole" To: "Nate Cole" , "Tom Beerbower" Cc: "Ambari" , "Jonathan Hurley" Date: Mon, 27 Oct 2014 19:15:13 -0000 Message-ID: <20141027191513.7137.69191@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/27230/ X-Sender: "Nate Cole" References: <20141027162118.7137.20996@reviews.apache.org> In-Reply-To: <20141027162118.7137.20996@reviews.apache.org> Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============6377441449161283831== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27230/#review58657 ----------------------------------------------------------- ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py Just curious, why a tuple and not a list? tuples are like struct's, heterogenous and lists are typically homogenous ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py May want to check into alternatives here, we've been burned with this when socket.getfqdn() doesn't return what the process is bound to. - Nate Cole On Oct. 27, 2014, 12:21 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27230/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 12:21 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-7986 > https://issues.apache.org/jira/browse/AMBARI-7986 > > > Repository: ambari > > > Description > ------- > > Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py PRE-CREATION > > Diff: https://reviews.apache.org/r/27230/diff/ > > > Testing > ------- > > Each script was tested against an installed cluster for each possible path: > 1) Invalid URLs > 2) URLs that return unexpected data > 3) URLs that return correct data > > > Thanks, > > Jonathan Hurley > > --===============6377441449161283831==--