Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============4581678705647947391=="
MIME-Version: 1.0
Subject: Re: Review Request 27194: Views: on deploy, validate view.xml
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Date: Mon, 27 Oct 2014 10:15:19 -0000
Message-ID: <20141027101519.7143.70669@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
References: <20141027025212.7138.12913@reviews.apache.org>
In-Reply-To: <20141027025212.7138.12913@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>

--===============4581678705647947391==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Oct. 27, 2014, 2:52 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, line 535
> > <https://reviews.apache.org/r/27194/diff/2/?file=733559#file733559line535>
> >
> >     Just a nit; I like to have boolean methods usually named with "is", such as isViewValidationEnabled()

I agree.  I thought I was following the convention for the class (i.e. boolean csrfProtectionEnabled()), but looking now I see that there really isn't a convention.  Your name is better.


> On Oct. 27, 2014, 2:52 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java, line 147
> > <https://reviews.apache.org/r/27194/diff/2/?file=733560#file733560line147>
> >
> >     Should the exception here be something other than a RuntimeException? Initially, I thought that IllegalStateException seemed wrong since calling this method at this time is a legal action; it's just the data that's invalid.
> >     
> >     But then I though that maybe this should be checked so that callers can decide how they want to handle the invalid view XML. Thoughts?
> >     
> >     I think it's good for now; no need to hold up the review on it, but it feels like a checked exception might be a better fit here.

Yes, I agree on this also.


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27194/#review58583
-----------------------------------------------------------


On Oct. 27, 2014, 12:42 a.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27194/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 12:42 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-7964
>     https://issues.apache.org/jira/browse/AMBARI-7964
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On view deploy: perform validation of view.xml in view package and if the view.xml does not validate, provide a specific error to the log.
> Validation can be an optional operation that can be enabled/disabled in the ambari server (maybe just a prop in ambari.properties view.validation.enabled=true/false)?
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 535e569 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java f5f2732 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java c4da8b4 
>   ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 12b5333 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewArchiveUtilityTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewExtractorTest.java 1b71c37 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 7c0cade 
>   ambari-server/src/test/resources/test_view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27194/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.  New unit tests added.  All existing pass ...
> 
> 
> Results :
> 
> Tests run: 2202, Failures: 0, Errors: 0, Skipped: 14
> 
> ...
> 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:45.663s
> [INFO] Finished at: Sat Oct 25 08:06:24 EDT 2014
> [INFO] Final Memory: 41M/344M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


--===============4581678705647947391==--