Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============1561366444125913300=="
MIME-Version: 1.0
Subject: Re: Review Request 27061: Pig Service Check, Tez,
 and WebHCat need dynamic tar properties in cluster-env.xml
From: "Jonathan Hurley" <jhurley@hortonworks.com>
To: "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Sid Wagle" <swagle@hortonworks.com>,
 "Jaimin Jetly" <jaimin@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Alejandro Fernandez" <afernandez@hortonworks.com>
Date: Thu, 23 Oct 2014 16:37:13 -0000
Message-ID: <20141023163713.1282.59253@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jonathan Hurley" <noreply@reviews.apache.org>
References: <20141023004924.1283.2078@reviews.apache.org>
In-Reply-To: <20141023004924.1283.2078@reviews.apache.org>
Reply-To: "Jonathan Hurley" <jhurley@hortonworks.com>

--===============1561366444125913300==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27061/#review58004
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Oct. 22, 2014, 8:49 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27061/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 8:49 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-7913
>     https://issues.apache.org/jira/browse/AMBARI-7913
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Pig Service Check fails because the cluster-env.xml file doesn't contain all of the following properties
> tez_tar_source, tez_tar_destination_folder
> hive_tar_source, hive_tar_destination_folder
> pig_tar_source, pig_tar_destination_folder
> hadoop-streaming_tar_source, hadoop-streaming_tar_destination_folder
> sqoop_tar_source, sqoop_tar_destination_folder
> 
> This happens because site_properties.js is not saving these to cluster-env.xml
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 5c7ea79 
>   ambari-web/app/data/HDP2/site_properties.js 541a6d0 
> 
> Diff: https://reviews.apache.org/r/27061/diff/
> 
> 
> Testing
> -------
> 
> Started up ambari-server, symlinked the web folder to my local working copy, and during the installation process verified that the following URL showed all of the properties,
> 
> http://c6403.ambari.apache.org:8080/api/v1/clusters/dev/configurations?type=cluster-env&tag=version1
> 
> When creating the cluster, selected HDFS, YARN, MR, Tez, Hive, Pig, Zookeeper, Sqoop.
> 
> After the deployment completed, verified that tez-site.xml contains tez.lib.uri with an actual path, e.g., hdfs:///apps/hdp/2.2.0.0-991/tez/tez-0.14.0.2.2.0.0-991.tar.gz
> Next, re-ran a service check on Pig, which passed.
> 
> Unit tests passed,
> Total run:669
> Total errors:0
> Total failures:0
> OK
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:13.750s
> [INFO] Finished at: Wed Oct 22 17:46:23 PDT 2014
> [INFO] Final Memory: 52M/492M
> [INFO] ------------------------------------------------------------------------
> 
> Pig Service Check results:
> 2014-10-23 00:41:56,977 - ExecuteHadoop['dfs -rmr pigsmoke.out passwd; hadoop --config /etc/hadoop/conf dfs -put /etc/passwd passwd '] {'security_enabled': False, 'keytab': [EMPTY], 'conf_dir': '/etc/hadoop/conf', 'try_sleep': 5, 'kinit_path_local': '', 'tries': 3, 'user': 'ambari-qa', 'bin_dir': '/usr/hdp/current/hadoop-client/bin'}
> 2014-10-23 00:41:56,978 - Execute['hadoop --config /etc/hadoop/conf dfs -rmr pigsmoke.out passwd; hadoop --config /etc/hadoop/conf dfs -put /etc/passwd passwd '] {'logoutput': False, 'path': ['/usr/hdp/current/hadoop-client/bin'], 'tries': 3, 'user': 'ambari-qa', 'try_sleep': 5}
> 2014-10-23 00:42:04,277 - File['/var/lib/ambari-agent/data/tmp/pigSmoke.sh'] {'content': StaticFile('pigSmoke.sh'), 'mode': 0755}
> 2014-10-23 00:42:04,288 - Execute['pig /var/lib/ambari-agent/data/tmp/pigSmoke.sh'] {'path': ['/usr/hdp/current/pig-client/bin:/usr/sbin:/sbin:/usr/local/bin:/bin:/usr/bin'], 'tries': 3, 'user': 'ambari-qa', 'try_sleep': 5}
> 2014-10-23 00:42:36,804 - ExecuteHadoop['fs -test -e pigsmoke.out'] {'bin_dir': '/usr/hdp/current/hadoop-client/bin', 'user': 'ambari-qa', 'conf_dir': '/etc/hadoop/conf'}
> 2014-10-23 00:42:36,806 - Execute['hadoop --config /etc/hadoop/conf fs -test -e pigsmoke.out'] {'logoutput': False, 'path': ['/usr/hdp/current/hadoop-client/bin'], 'tries': 1, 'user': 'ambari-qa', 'try_sleep': 0}
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


--===============1561366444125913300==--