Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC8311787E for ; Tue, 21 Oct 2014 14:46:35 +0000 (UTC) Received: (qmail 40547 invoked by uid 500); 21 Oct 2014 14:46:35 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 40517 invoked by uid 500); 21 Oct 2014 14:46:35 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 40497 invoked by uid 99); 21 Oct 2014 14:46:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Oct 2014 14:46:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6B59B1DDEC7; Tue, 21 Oct 2014 14:46:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9073112212176456189==" MIME-Version: 1.0 Subject: Re: Review Request 26972: Add Service should not be setting HDFS configs when HDFS is not present From: "Alexandr Antonenko" To: "Andriy Babiichuk" , "Aleksandr Kovalenko" Cc: "Andrii Tkach" , "Alexandr Antonenko" , "Ambari" Date: Tue, 21 Oct 2014 14:46:40 -0000 Message-ID: <20141021144640.1282.60012@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Alexandr Antonenko" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/26972/ X-Sender: "Alexandr Antonenko" References: <20141021144429.1282.72407@reviews.apache.org> In-Reply-To: <20141021144429.1282.72407@reviews.apache.org> Reply-To: "Alexandr Antonenko" X-ReviewRequest-Repository: ambari --===============9073112212176456189== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26972/#review57579 ----------------------------------------------------------- Ship it! Ship It! - Alexandr Antonenko On Oct. 21, 2014, 2:44 p.m., Andrii Tkach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26972/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 2:44 p.m.) > > > Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko. > > > Bugs: AMBARI-7883 > https://issues.apache.org/jira/browse/AMBARI-7883 > > > Repository: ambari > > > Description > ------- > > 1) Install a cluster w/o HDFS (for example, just kafka, or just storm, or just knox) > 2) go an add service (add something that doesn't need HDFS) > 3) when add service is complete, HDFS configs have been rev'd and show up under Config History > Issue is: there is no HDFS. Add Service should not be setting any HDFS configs when HDFS is not installed. > > > Diffs > ----- > > ambari-web/app/controllers/wizard/step8_controller.js 470c876 > ambari-web/test/controllers/wizard/step8_test.js 087badc > > Diff: https://reviews.apache.org/r/26972/diff/ > > > Testing > ------- > > 4696 tests complete (8 seconds) > 60 tests pending > > > Thanks, > > Andrii Tkach > > --===============9073112212176456189==--