Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 939D717CBB for ; Mon, 20 Oct 2014 10:48:34 +0000 (UTC) Received: (qmail 68473 invoked by uid 500); 20 Oct 2014 10:48:34 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 68444 invoked by uid 500); 20 Oct 2014 10:48:34 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 68410 invoked by uid 99); 20 Oct 2014 10:48:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Oct 2014 10:48:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4B1291D42ED; Mon, 20 Oct 2014 10:48:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8620614050614456410==" MIME-Version: 1.0 Subject: Re: Review Request 26920: Slider app's Quick Links combobox contains repetitive items From: "Aleksandr Kovalenko" To: "Andrii Tkach" , "Andriy Babiichuk" , "Aleksandr Kovalenko" Cc: "Oleg Nechiporenko" , "Ambari" Date: Mon, 20 Oct 2014 10:48:39 -0000 Message-ID: <20141020104839.1282.79820@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aleksandr Kovalenko" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/26920/ X-Sender: "Aleksandr Kovalenko" References: <20141020104722.1283.29665@reviews.apache.org> In-Reply-To: <20141020104722.1283.29665@reviews.apache.org> Reply-To: "Aleksandr Kovalenko" X-ReviewRequest-Repository: ambari --===============8620614050614456410== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26920/#review57312 ----------------------------------------------------------- Ship it! Ship It! - Aleksandr Kovalenko On Жов. 20, 2014, 10:47 до полудня, Oleg Nechiporenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26920/ > ----------------------------------------------------------- > > (Updated Жов. 20, 2014, 10:47 до полудня) > > > Review request for Ambari, Andriy Babiichuk, Aleksandr Kovalenko, and Andrii Tkach. > > > Bugs: AMBARI-7853 > https://issues.apache.org/jira/browse/AMBARI-7853 > > > Repository: ambari > > > Description > ------- > > Steps: > # Create Slider view and go to it. > # Add some apps (were used HBASE). > # Stop and destroy some (not all apps). > # Go to leaving app and open Quick Links combobox. > > Result: Quick Links combobox contains repetitive items > > > Diffs > ----- > > contrib/views/slider/src/main/resources/ui/app/controllers/slider_app_controller.js 15792ef > contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_app_controller_test.js c022d24 > > Diff: https://reviews.apache.org/r/26920/diff/ > > > Testing > ------- > > Tests completed in 7140 milliseconds. > 124 assertions of 124 passed, 0 failed. > > > Thanks, > > Oleg Nechiporenko > > --===============8620614050614456410==--