Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9302B17DC8 for ; Thu, 16 Oct 2014 16:25:19 +0000 (UTC) Received: (qmail 41574 invoked by uid 500); 16 Oct 2014 16:25:19 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 41543 invoked by uid 500); 16 Oct 2014 16:25:19 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 41529 invoked by uid 99); 16 Oct 2014 16:25:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Oct 2014 16:25:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B40841DF389; Thu, 16 Oct 2014 16:25:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8750286833550331542==" MIME-Version: 1.0 Subject: Re: Review Request 26757: HBase Master CPU utilization alert is not suppressed at MM From: "Dmytro Sen" To: "Nate Cole" , "Dmytro Sen" Cc: "Dmitro Lisnichenko" , "Ambari" Date: Thu, 16 Oct 2014 16:25:14 -0000 Message-ID: <20141016162514.24426.93657@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/26757/ X-Sender: "Dmytro Sen" References: <20141016162009.24426.30840@reviews.apache.org> In-Reply-To: <20141016162009.24426.30840@reviews.apache.org> Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============8750286833550331542== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26757/#review56927 ----------------------------------------------------------- Ship it! Ship It! - Dmytro Sen On Окт. 16, 2014, 4:20 п.п., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26757/ > ----------------------------------------------------------- > > (Updated Окт. 16, 2014, 4:20 п.п.) > > > Review request for Ambari, Dmytro Sen and Nate Cole. > > > Bugs: AMBARI-7791 > https://issues.apache.org/jira/browse/AMBARI-7791 > > > Repository: ambari > > > Description > ------- > > At jira https://issues.apache.org/jira/browse/AMBARI-6358 we had a requirement to have only one 'HBase Master CPU utilization' check even in HA mode. So this check is bound to Nagios host (to be executed only once even if hbase master hostgroup has more than one host, like it is done for "* Percent Count" alerts). As a result, Hbase Master alert origin data does not match any entry at file /var/nagios/ignore.dat . That's why the alert is not suppressed. > > Fixed many similar issues with other checks. Had to add a new check wrapper for that. > > > Diffs > ----- > > ambari-server/src/main/python/ambari-server.py 4988708 > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh 8c36a79 > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/mm_wrapper.py PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py 4d452c6 > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 a81762f > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 6ce5d10 > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/nagios.cfg.j2 aa37a01 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_checkpoint_time.py 6848e17 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh d350e4f > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/mm_wrapper.py PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py 4efce9b > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 9a6f7a4 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 1ed55d1 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/nagios.cfg.j2 d51471b > ambari-server/src/test/python/stacks/1.3.2/NAGIOS/test_mm_wrapper.py PRE-CREATION > ambari-server/src/test/python/stacks/1.3.2/NAGIOS/test_nagios_server.py d5a35bc > ambari-server/src/test/python/stacks/2.0.6/NAGIOS/test_mm_wrapper.py PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/NAGIOS/test_nagios_server.py 3e4ea26 > ambari-server/src/test/python/unitTests.py 773a698 > > Diff: https://reviews.apache.org/r/26757/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 234 tests in 4.714s > > OK > ---------------------------------------------------------------------- > Total run:664 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmitro Lisnichenko > > --===============8750286833550331542==--