Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 193C917A9E for ; Thu, 16 Oct 2014 06:20:11 +0000 (UTC) Received: (qmail 59054 invoked by uid 500); 16 Oct 2014 06:20:11 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 59023 invoked by uid 500); 16 Oct 2014 06:20:11 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 59009 invoked by uid 99); 16 Oct 2014 06:20:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Oct 2014 06:20:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 541041DF359; Thu, 16 Oct 2014 06:20:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7230920696718633375==" MIME-Version: 1.0 Subject: Review Request 26804: Knox custom commands are shown twice in the service menu From: "Jaimin Jetly" To: "Yusaku Sako" , "Srimanth Gunturi" Cc: "Ambari" , "Jaimin Jetly" Date: Thu, 16 Oct 2014 06:20:06 -0000 Message-ID: <20141016062006.24414.48836@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jaimin Jetly" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/26804/ X-Sender: "Jaimin Jetly" Reply-To: "Jaimin Jetly" X-ReviewRequest-Repository: ambari --===============7230920696718633375== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26804/ ----------------------------------------------------------- Review request for Ambari, Srimanth Gunturi and Yusaku Sako. Bugs: AMBARI-7805 https://issues.apache.org/jira/browse/AMBARI-7805 Repository: ambari Description ------- The custom commands for knox are stated explicity in the customaction map and needs to be excluded. Also the service version for knox is incorrect in the knox metainfo.xml file Diffs ----- ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php 878f0dc ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py e1100c4 ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 0aa4b68 ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 1ed55d1 ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json f8eb4c7 ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-broker.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-env.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-log4j.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/metainfo.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/kafka.py PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/kafka_broker.py PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/properties_config.py PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/service_check.py PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/status_params.py PRE-CREATION ambari-server/src/test/python/stacks/2.2/KAFKA/test_kafka_broker.py PRE-CREATION ambari-server/src/test/python/stacks/2.2/configs/default.json 5e984fe ambari-web/app/data/HDP2/site_properties.js f6b1862 ambari-web/app/models/service_config.js 664ca62 ambari-web/app/models/stack_service.js 7f64212 Diff: https://reviews.apache.org/r/26804/diff/ Testing ------- tested the patch e2e on live cluster Thanks, Jaimin Jetly --===============7230920696718633375==--