Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3581587163443504103=="
MIME-Version: 1.0
Subject: Review Request 26793: Views: Instance Data Storage doesn't work
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Date: Thu, 16 Oct 2014 01:43:34 -0000
Message-ID: <20141016014334.24413.25019@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>

--===============3581587163443504103==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26793/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-7806
    https://issues.apache.org/jira/browse/AMBARI-7806


Repository: ambari


Description
-------

Problem detected in Pig, but it seems that it's problem with storage (getInstanceData / putInstanceData) APIs

Ambari from repo http://s3.amazonaws.com/dev.hortonworks.com/ambari/centos6/1.x/updates/1.6.1.trunk/ambari.repo

{noformat}
Service 'storage' check failed:
Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.4.0.v20120608-r11652): 
org.eclipse.persistence.exceptions.DatabaseException Internal Exception: 
java.sql.BatchUpdateException: 
Batch entry 0 INSERT INTO viewinstance (view_instance_id, DESCRIPTION, ICON, ICON64, LABEL, name, VISIBLE, view_name) VALUES (46, NULL, NULL, NULL, NULL, 'MyPig', 'Y', 'PIG{0.1.0}') was aborted.
Call getNextException to see the cause. Error Code: 0
Call: INSERT INTO viewinstance (view_instance_id, DESCRIPTION, ICON, ICON64, LABEL, name, VISIBLE, view_name) VALUES (?, ?, ?, ?, ?, ?, ?, ?) bind => [8 parameters bound]
Query: InsertObjectQuery(org.apache.ambari.server.orm.entities.ViewInstanceDataEntity@16088779)
{noformat}

-----

Ensure that id and instance data are set on static view instances loaded from view archive.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java f5dc8b9 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java ffcac6b 

Diff: https://reviews.apache.org/r/26793/diff/


Testing
-------

Manual testing.

Test updated.  All existing tests pass ...

Results :

Tests run: 2107, Failures: 0, Errors: 0, Skipped: 18

…

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:50.110s
[INFO] Finished at: Wed Oct 15 20:57:16 EDT 2014
[INFO] Final Memory: 38M/482M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


--===============3581587163443504103==--