Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 902C710CA6 for ; Wed, 15 Oct 2014 16:36:33 +0000 (UTC) Received: (qmail 17802 invoked by uid 500); 15 Oct 2014 16:36:33 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 17777 invoked by uid 500); 15 Oct 2014 16:36:33 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 17758 invoked by uid 99); 15 Oct 2014 16:36:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 16:36:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 99BF71DDFB0; Wed, 15 Oct 2014 16:36:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0945923300822801358==" MIME-Version: 1.0 Subject: Re: Review Request 26754: Slider Wizard, step 3, add property modal error From: "Andrii Tkach" To: "Andriy Babiichuk" , "Aleksandr Kovalenko" Cc: "Andrii Tkach" , "Oleg Nechiporenko" , "Ambari" Date: Wed, 15 Oct 2014 16:36:28 -0000 Message-ID: <20141015163628.24426.13199@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Andrii Tkach" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/26754/ X-Sender: "Andrii Tkach" References: <20141015162411.24426.9417@reviews.apache.org> In-Reply-To: <20141015162411.24426.9417@reviews.apache.org> Reply-To: "Andrii Tkach" X-ReviewRequest-Repository: ambari --===============0945923300822801358== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26754/#review56718 ----------------------------------------------------------- Ship it! Ship It! - Andrii Tkach On Окт. 15, 2014, 4:24 п.п., Oleg Nechiporenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26754/ > ----------------------------------------------------------- > > (Updated Окт. 15, 2014, 4:24 п.п.) > > > Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko. > > > Bugs: AMBARI-7790 > https://issues.apache.org/jira/browse/AMBARI-7790 > > > Repository: ambari > > > Description > ------- > > Add-property modal shouldn't hide after click "Add" if some errors with new config. > > > Diffs > ----- > > contrib/views/slider/src/main/resources/ui/app/components/configSection.js a1608d2 > contrib/views/slider/src/main/resources/ui/app/templates/components/configSection.hbs 326218a > contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js 361db08 > > Diff: https://reviews.apache.org/r/26754/diff/ > > > Testing > ------- > > Tests completed in 6216 milliseconds. > 102 assertions of 102 passed, 0 failed. > > > Thanks, > > Oleg Nechiporenko > > --===============0945923300822801358==--