Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8882192154651267860=="
MIME-Version: 1.0
Subject: Re: Review Request 26744: Alerts: Expose Alert Notices via REST APIs
From: "Nate Cole" <ncole@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Date: Wed, 15 Oct 2014 14:14:28 -0000
Message-ID: <20141015141428.24413.4485@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Nate Cole" <noreply@reviews.apache.org>
References: <20141015123542.24426.35373@reviews.apache.org>
In-Reply-To: <20141015123542.24426.35373@reviews.apache.org>
Reply-To: "Nate Cole" <ncole@hortonworks.com>

--===============8882192154651267860==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26744/#review56702
-----------------------------------------------------------

Ship it!


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java
<https://reviews.apache.org/r/26744/#comment97086>

    Code indicates you could extend ReadOnlyResourceProvider; but, meh, this works too.


ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java
<https://reviews.apache.org/r/26744/#comment97087>

    Nit: doc doesn't match method.


- Nate Cole


On Oct. 15, 2014, 8:35 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26744/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 8:35 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-7778
>     https://issues.apache.org/jira/browse/AMBARI-7778
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For every outbound notification, Ambari currently keeps track of the dispatch state (PENDING, DELIVERED, FAILURE). This data needs to be exposed via the REST APIs so that it can be queried.
> 
> {code}
> http://localhost:8080/api/v1/clusters/c1/alert_notices?fields=*
> http://localhost:8080/api/v1/clusters/c1/alert_notices?AlertNotice/notification_state=DELIVERED&fields=*
> 
> {
>   "href" : "http://localhost:8080/api/v1/clusters/c1/alert_notices?fields=*",
>   "items" : [
>     {
>       "href" : "http://localhost:8080/api/v1/clusters/c1/alert_notices/1",
>       "AlertNotice" : {
>         "cluster_name" : "c1",
>         "history_id" : 1,
>         "id" : 1,
>         "notification_state" : "DELIVERED",
>         "service_name" : "HDFS",
>         "target_id" : 1,
>         "target_name" : "Administrators",
>         "uuid" : "106ecdb4-0970-4c50-22d3-706d53571321"
>       }
>     },
>     {
>       "href" : "http://localhost:8080/api/v1/clusters/c1/alert_notices/2",
>       "AlertNotice" : {
>         "cluster_name" : "c1",
>         "history_id" : 2,
>         "id" : 2,
>         "notification_state" : "DELIVERED",
>         "service_name" : "HDFS",
>         "target_id" : 1,
>         "target_name" : "Administrators",
>         "uuid" : "fffecdb4-0970-4dd0-22d3-706d53571321"
>       }
>     }
>   ]
> }
> {code}
> 
> Same as with history, pagination and sorting will be done together tracked by another single Jira.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertNoticeResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c7a3277 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertNoticeService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java e039b6a 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java 7962ee3 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java 7371fad 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AlertNoticeRequest.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java d428b80 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java 05ae105 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 40bcb62 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 4fb8319 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java 45d0734 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java 2239c8f 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity_.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity_.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProviderTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/AlertDaoHelper.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java 015acc0 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java c3da07f 
> 
> Diff: https://reviews.apache.org/r/26744/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:05 min
> [INFO] Finished at: 2014-10-14T20:28:54-04:00
> [INFO] Final Memory: 29M/237M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


--===============8882192154651267860==--