Return-Path: 
 <dev-return-40998-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id AE708174EB
	for <apmail-ambari-dev-archive@www.apache.org>;
 Sun, 12 Oct 2014 13:33:59 +0000 (UTC)
Received: (qmail 25479 invoked by uid 500); 12 Oct 2014 13:33:59 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 25445 invoked by uid 500); 12 Oct 2014 13:33:59 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 25425 invoked by uid 99); 12 Oct 2014 13:33:59 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Oct 2014 13:33:59 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id EAF701D4301;
	Sun, 12 Oct 2014 13:33:54 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============1503351523230932950=="
MIME-Version: 1.0
Subject: Re: Review Request 26599: Slider View: set admin password param as
 masked
From: "Andrii Tkach" <atkach@hortonworks.com>
To: "Oleg Nechiporenko" <onechiporenko@apache.org>
Cc: "Andrii Tkach" <atkach@hortonworks.com>,
 "Andriy Babiichuk" <ababiichuk@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Sun, 12 Oct 2014 13:33:54 -0000
Message-ID: <20141012133354.24413.91938@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Andrii Tkach" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-ReviewRequest-URL: https://reviews.apache.org/r/26599/
X-Sender: "Andrii Tkach" <noreply@reviews.apache.org>
References: <20141011155626.15371.5446@reviews.apache.org>
In-Reply-To: <20141011155626.15371.5446@reviews.apache.org>
Reply-To: "Andrii Tkach" <atkach@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============1503351523230932950==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26599/#review56346
-----------------------------------------------------------

Ship it!


Ship It!

- Andrii Tkach


On Окт. 11, 2014, 3:56 п.п., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26599/
> -----------------------------------------------------------
> 
> (Updated Окт. 11, 2014, 3:56 п.п.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7746
>     https://issues.apache.org/jira/browse/AMBARI-7746
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> https://github.com/apache/ambari/blob/trunk/contrib/views/slider/src/main/resources/view.xml
> 
> Need to set this paramater as <masked>true</masked>
> 
> {code}
> 	<parameter>
> <name>ambari.server.password</name>
> <description>Ambari administrator password (for example: admin)
> </description>
> <required>true</required>
> </parameter>
> {code}
> 
> 
> Also, change the descriptions on these properties:
> 
> |ambari.server.username|Cluster Operator username (for example: admin)|
> |ambari.server.password|
> |Cluster Operator password (for example: admin)|
> 
> Because you don't need to be an ambari admin, you need to be at least a cluster operator.
> 
> 
> Diffs
> -----
> 
>   contrib/views/slider/src/main/resources/view.xml 5dcc397 
> 
> Diff: https://reviews.apache.org/r/26599/diff/
> 
> 
> Testing
> -------
> 
> didn't add tests - small xml changes
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>


--===============1503351523230932950==--