Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4569117BE3 for ; Wed, 8 Oct 2014 16:01:37 +0000 (UTC) Received: (qmail 34188 invoked by uid 500); 8 Oct 2014 16:01:37 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 34161 invoked by uid 500); 8 Oct 2014 16:01:37 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 34143 invoked by uid 99); 8 Oct 2014 16:01:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 16:01:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7B53E1DDD4F; Wed, 8 Oct 2014 16:01:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3326556970400490169==" MIME-Version: 1.0 Subject: Re: Review Request 24845: Config_data column should be consistent across tables From: "Dmytro Sen" To: "Myroslav Papirkovskyy" Cc: "Dmytro Sen" , "Ambari" Date: Wed, 08 Oct 2014 16:01:32 -0000 Message-ID: <20141008160132.24817.18509@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/24845/ X-Sender: "Dmytro Sen" References: <20141008160006.15371.78220@reviews.apache.org> In-Reply-To: <20141008160006.15371.78220@reviews.apache.org> Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============3326556970400490169== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24845/ ----------------------------------------------------------- (Updated Окт. 8, 2014, 4:01 п.п.) Review request for Ambari and Myroslav Papirkovskyy. Bugs: AMBARI-6911 https://issues.apache.org/jira/browse/AMBARI-6911 Repository: ambari Description ------- config_data column has different types in different tables in MySQL and Postgres. MySQL clusterconfig - LONGTEXT blueprint_configuration - VARCHAR(32000) hostgroup_configuration - TEXT Postgres & embedded clusterconfig - VARCHAR(32000) blueprint_configuration - varchar(32000) hostgroup_configuration - TEXT If we want this fixed, we should take care of upgrading Ambari also. MySQL should be mapped to LONGTEXT Postrges to TEXT Oracle to CLOB Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntity.java 1495704 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java da8fac6 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntity.java cc4e0c6 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java d3fdd3b ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 144900e ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fe39612 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 25d973f ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2d5b267 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 515f8cd ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 6262a2b Diff: https://reviews.apache.org/r/24845/diff/ Testing ------- Unit tests + manually deployed on Mysql, Oracle, Postgres, Postgres-Embedded , tested upgrade on Postgres 1.6.0 -> 1.6.1 > 1.7.0, 1.6.1 -> 1.7.0, 1.6.0 -> 1.7.0 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 21:45.128s Thanks, Dmytro Sen --===============3326556970400490169==--