Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CC11D17E8A for ; Wed, 8 Oct 2014 10:32:05 +0000 (UTC) Received: (qmail 22719 invoked by uid 500); 8 Oct 2014 10:32:05 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 22681 invoked by uid 500); 8 Oct 2014 10:32:05 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 22667 invoked by uid 99); 8 Oct 2014 10:32:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 10:32:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7DECA1DBB63; Wed, 8 Oct 2014 10:32:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5439025058619595053==" MIME-Version: 1.0 Subject: Re: Review Request 26413: Stack API generates invalid json files at "content" area From: "Dmytro Sen" To: "Dmytro Sen" , "Tom Beerbower" Cc: "Ambari" , "Dmitro Lisnichenko" Date: Wed, 08 Oct 2014 10:32:01 -0000 Message-ID: <20141008103201.24817.58171@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/26413/ X-Sender: "Dmytro Sen" References: <20141008102857.15371.55247@reviews.apache.org> In-Reply-To: <20141008102857.15371.55247@reviews.apache.org> Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============5439025058619595053== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26413/#review55781 ----------------------------------------------------------- Are unit tests still fail ? - Dmytro Sen On Окт. 8, 2014, 10:28 д.п., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26413/ > ----------------------------------------------------------- > > (Updated Окт. 8, 2014, 10:28 д.п.) > > > Review request for Ambari, Dmytro Sen and Tom Beerbower. > > > Bugs: AMBARI-7676 > https://issues.apache.org/jira/browse/AMBARI-7676 > > > Repository: ambari > > > Description > ------- > > Content of files that is presented at /api/v1/stacks/HDP/versions/2.2/services/HDFS/configurations/content# generates invalid json. Commas are missing between sections. > Result of validation: > Error: Parse error on line 14: > ...fs-log4j.xml" }} { "href" : "http:/ > ---------------------^ > Expecting 'EOF', '}', ',', ']' > I've attached JSON I've got > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/api/services/serializers/JsonSerializer.java 59d5a8a > ambari-server/src/test/java/org/apache/ambari/server/api/services/serializers/JsonSerializerTest.java 90063a0 > > Diff: https://reviews.apache.org/r/26413/diff/ > > > Testing > ------- > > [INFO] ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [3.560s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.257s] > [INFO] Ambari Web ........................................ SUCCESS [33.899s] > [INFO] Ambari Views ...................................... SUCCESS [1.492s] > [INFO] Ambari Admin View ................................. SUCCESS [8.862s] > [INFO] Ambari Server ..................................... FAILURE [21:30.575s] > [INFO] Ambari Agent ...................................... SKIPPED > [INFO] Ambari Client ..................................... SKIPPED > [INFO] Ambari Python Client .............................. SKIPPED > [INFO] Ambari Groovy Client .............................. SKIPPED > [INFO] Ambari Shell ...................................... SKIPPED > [INFO] Ambari Python Shell ............................... SKIPPED > [INFO] Ambari Groovy Shell ............................... SKIPPED > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 22:19.290s > [INFO] Finished at: Tue Oct 07 19:55:33 FET 2014 > [INFO] Final Memory: 33M/396M > [INFO] ------------------------------------------------------------------------ > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12:test (default-test) > > Tests are failing on trunk. Will retest later. > > > Thanks, > > Dmitro Lisnichenko > > --===============5439025058619595053==--