Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============1844181573659948845=="
MIME-Version: 1.0
Subject: Review Request 26412: Alerts: Service-level Definitions Should Be
 Processed by the Service Master
From: "Jonathan Hurley" <jhurley@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Date: Tue, 07 Oct 2014 15:09:33 -0000
Message-ID: <20141007150933.15371.18763@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jonathan Hurley" <noreply@reviews.apache.org>
Reply-To: "Jonathan Hurley" <jhurley@hortonworks.com>

--===============1844181573659948845==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26412/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-7673
    https://issues.apache.org/jira/browse/AMBARI-7673


Repository: ambari


Description
-------

The actual issue is that AGGREGATE alerts were attempting to be scheduled on the service masters. AGGREGATE type alerts should not trigger hash invalidations.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java e4aa22241d123ae48d367eb2b1baf58d2e628e12 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 10cd54ab0836e5e8cde7b4b29dba9b15fdf932ed 
  ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java 412b4d35bd74a8229f98094ea23b74f1f3a0de50 

Diff: https://reviews.apache.org/r/26412/diff/


Testing
-------

Added a test to verify that:
- AGGREGATE alerts don't trigger hash invalidations
- Definitions that are service-level do cause a host invalidation

Existing tests are busted (see https://builds.apache.org/job/Ambari-trunk-Commit/). I ran the tests anyway and verified that the same ones failed, so there should not be more regressions from my changes. 

Once trunk is fixed, I'll re-run the tests and push (assuming I get +1's on the changes).


Thanks,

Jonathan Hurley


--===============1844181573659948845==--